Skip to content

CC-8800: accept durable object app ids in container commands - #15980

Merged
martinezjandrew merged 1 commit into
mainfrom
amartinez/fix-containers-id
Oct 1, 2026
Merged

CC-8800: accept durable object app ids in container commands#15980
martinezjandrew merged 1 commit into
mainfrom
amartinez/fix-containers-id

Conversation

@martinezjandrew

@martinezjandrew martinezjandrew commented Sep 30, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #CC-8800.

Issue

containers delete {app_id} and containers instances {app_id} validate against legacy container ids. We introduced a new runtime that uses durable object ids as application ids. This means that both the delete container and list instances commands break for new runtime applications.

Solution

We now validate regex for both legacy container ids and new runtime durable object ids.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Fixing existing features
image

Devin Review

@changeset-bot

changeset-bot Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8d6d9cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 30, 2026
@workers-devprod
workers-devprod requested review from a team and dario-piotrowicz and removed request for a team September 30, 2026 19:09
@workers-devprod

workers-devprod commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Sep 30, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ask-bonk

ask-bonk Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15980

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15980

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15980

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15980

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15980

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15980

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15980

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15980

miniflare

npm i https://pkg.pr.new/miniflare@15980

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15980

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15980

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@15980

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15980

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15980

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15980

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15980

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15980

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15980

wrangler

npm i https://pkg.pr.new/wrangler@15980

commit: 8d6d9cc

dario-piotrowicz
dario-piotrowicz approved these changes Oct 1, 2026
View reviewed changes

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

workers-devprod
workers-devprod approved these changes Oct 1, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@martinezjandrew
martinezjandrew enabled auto-merge (squash) October 1, 2026 15:26
@martinezjandrew
martinezjandrew force-pushed the amartinez/fix-containers-id branch from 069ad49 to 8d6d9cc Compare October 1, 2026 16:16
@martinezjandrew
martinezjandrew merged commit 90e6a1b into main Oct 1, 2026
55 checks passed
@martinezjandrew
martinezjandrew deleted the amartinez/fix-containers-id branch October 1, 2026 17:16
@workers-devprod workers-devprod mentioned this pull request Oct 1, 2026
Merged
@brandhaug brandhaug mentioned this pull request Oct 5, 2026
Merged
brandhaug added a commit to brandhaug/b2b-saas-starter that referenced this pull request Oct 5, 2026
@brandhaug @github-actions
chore(deps): bump wrangler from 4.146.0 to 4.147.0 (#583)
caf4756 
## pnpm-workspace.yaml (default)

## Dependency Updates

| Package | From | To | Type |
| --- | --- | --- | --- |
| `wrangler` | 4.146.0 | 4.147.0 | minor |

## Release Notes

<details>
<summary><b>wrangler</b> (4.146.0 → 4.147.0)</summary>

### Minor Changes

- [#15928](cloudflare/workers-sdk#15928)
[`7f57b1c`](cloudflare/workers-sdk@7f57b1c)
Thanks [@<!---->ichernetsky-cf](https://github.com/ichernetsky-cf)! -
Allow `"us"` as a jurisdiction for Container applications

Container placement constraints now accept `constraints.jurisdiction:
"us"` in Wrangler and typed Cloudflare configuration. This makes the US
jurisdiction available alongside `"eu"` and `"fedramp"`.

### Patch Changes

- [#15974](cloudflare/workers-sdk#15974)
[`7f700ef`](cloudflare/workers-sdk@7f700ef)
Thanks [@<!---->martinezjandrew](https://github.com/martinezjandrew)! -
Fix `wrangler containers list` to report live instances

The `LIVE INSTANCES` column now reports each application's active
runtime instances instead of its configured instance count, matching the
Cloudflare dashboard. JSON output continues to expose the configured
count through the existing `instances` field.

- [#15980](cloudflare/workers-sdk#15980)
[`90e6a1b`](cloudflare/workers-sdk@90e6a1b)
Thanks [@<!---->martinezjandrew](https://github.com/martinezjandrew)! -
Accept Durable Object application IDs in Containers commands

`wrangler containers instances` and `wrangler containers delete` now
accept the 32-character hexadecimal application IDs returned for Durable
Object-backed applications, in addition to legacy dashed UUIDs.

- [#15871](cloudflare/workers-sdk#15871)
[`6a4b0fe`](cloudflare/workers-sdk@6a4b0fe)
Thanks [@<!---->tw4](https://github.com/tw4)! - Retry transient API
failures in `wrangler workflows instances list` and `wrangler workflows
instances describe`

Previously, a single temporary 5xx response or dropped connection made
these read-only commands

…[full
notes](https://github.com/cloudflare/workers-sdk/releases/tag/wrangler%404.147.0)

</details>

---
*This PR was auto-generated by
[catalog-update-action](https://github.com/brandhaug/catalog-update-action).*

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@skepticfx skepticfx skepticfx approved these changes
@gpanders gpanders gpanders approved these changes
@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes
@rushilmehra rushilmehra rushilmehra approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@martinezjandrew @workers-devprod @skepticfx @gpanders @dario-piotrowicz @rushilmehra