Repository navigation
Retry deployments - #6801
Retry deployments#6801
Conversation
🦋 Changeset detectedLatest commit: d050578 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-wrangler-6801You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6801/npm-package-wrangler-6801Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-wrangler-6801 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-create-cloudflare-6801 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-cloudflare-kv-asset-handler-6801npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-miniflare-6801npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-cloudflare-pages-shared-6801npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-cloudflare-vitest-pool-workers-6801npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-cloudflare-workers-editor-shared-6801npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11123200983/npm-package-cloudflare-workers-shared-6801Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
Thank you for this!! The flakiness in deploying made my deploy CI job so unreliable (to the point that I added a retry wrapper script around |
0a01788 to
b92c696
Compare
andyjessop
left a comment
andyjessop
left a comment
There was a problem hiding this comment.
Very nice 👍
One question I have is do we know this is going to fix the problem, Or will it just make failed runs take longer?
I added up to 3 retries to my deployments months ago and have never had a flake since. Before that, it seemed like it had a 30% chance of failure due to 5XX errors. |
Failures due to flakey internet or backend will be fixed by this. This will improve the happy path for successful deployments. If there is a legit reason for failure, we can iterate on this solution to bail out of the retries – but I think for now we should optimise for the happy path here and take the hit of a few seconds on the sad path. |
|
|
||
| export async function retryOnError<T>( | ||
| action: () => T | Promise<T>, | ||
| backoff = 2_000, |
There was a problem hiding this comment.
this signature means you have to pass a backoff if you want to define attempts, which isn't ideal. Can we put backoff and attempts into an options object instead, with both fields being optional?
| throw err; | ||
| } | ||
|
|
||
| await setTimeout(backoff); |
There was a problem hiding this comment.
should the default be 0? what would a 2 second wait (by default) accomplish?
What this PR solves / how to test
This PR adds retries within
wrangler deployandwrangler versions uploadto workaround spotty network connections and service flakesWe need to be careful about retrying the whole multi-step process because of some non-atomic steps.
Users have reported flakes at the upload step so we can safely add retries for that step to address those specific failures.
Fixes #0000
Author has addressed the following