Remove fog-local and fog-openstack blobstore support#5197
Open
WeiQuan0605 wants to merge 3 commits into
Open
Conversation
Drop the fog-local and fog-openstack gems, remove all related code paths in FogClient (local? method, Local storage branch in files_for, OpenStack limit workaround, local endpoint override), and migrate all test specs from real-filesystem fog-local mocks to in-memory fog-aws mocks.
local? is a required interface method declared in client.rb and forwarded by RetryableClient/SafeDeleteClient/ErrorHandlingClient via Forwardable. FogClient is never local, so it always returns false.
WeiQuan0605
force-pushed
the
Remove-fog-local-and-openstack
branch
from
0ee8209 to
568022d
Compare
Remove tests that relied on fog-local's local? behavior (nginx X-Accel-Redirect, direct body serving) since the fog-local provider no longer exists. Replace with redirect-based behavior tests that reflect the actual current code path. Fix Fog.mock! handling in test_config.rb to no longer check fog provider name for 'local'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Remove fog-local and fog-openstack gem dependencies and all related code paths.
An explanation of the use cases your change solves
fog-local and fog-openstack are legacy blobstore providers that are no longer used in production Cloud Foundry deployments. They have no migration path in storage-cli, which is the recommended replacement for all fog-based blobstores. Removing them reduces the gem surface area, eliminates dead code branches in FogClient, and removes a real-filesystem dependency from the test suite that caused unnecessary I/O and cleanup complexity.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests