Skip to content

CldVideoPlayer custom CNAME - #348

Merged
colbyfayock merged 2 commits into
mainfrom
feat/347-cname
Nov 15, 2023
Merged

CldVideoPlayer custom CNAME#348
colbyfayock merged 2 commits into
mainfrom
feat/347-cname

Conversation

@colbyfayock

@colbyfayock colbyfayock commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

Description

Adds types for the config options that allow to set a custom CNAME.

When secure = true (default):

secureDistribution="mycname"
privateCdn={true}

When secure = false:

cname="mycname"
privateCdn={true}

Issue Ticket Number

Fixes #347

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel

vercel Bot commented Nov 15, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Nov 15, 2023 2:42am

@colbyfayock
colbyfayock merged commit bcb54c6 into main Nov 15, 2023
@colbyfayock
colbyfayock deleted the feat/347-cname branch November 15, 2023 02:43
github-actions Bot pushed a commit that referenced this pull request Nov 15, 2023
@semantic-release-bot
chore(release): 5.7.0 [skip ci]
18512e8 
# [5.7.0](v5.6.0...v5.7.0) (2023-11-15)

### Features

* CldVideoPlayer custom CNAME ([#348](#348)) ([bcb54c6](bcb54c6)), closes [#347](#347)
@github-actions

github-actions Bot commented Nov 15, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lytro-dev pushed a commit to lytro-dev/next-image-delivery that referenced this pull request Dec 23, 2023
@00100011-dev
chore(release): 5.7.0 [skip ci]
d30ea63 
# [5.7.0](cloudinary-community/next-cloudinary@v5.6.0...v5.7.0) (2023-11-15)

### Features

* CldVideoPlayer custom CNAME ([#348](cloudinary-community/next-cloudinary#348)) ([bcb54c6](cloudinary-community/next-cloudinary@bcb54c6)), closes [#347](cloudinary-community/next-cloudinary#347)

This branch was successfully deployed

1 active deployment
Preview — 8e91522f Deployed Nov 15, 2023 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Custom Cname

1 participant

@colbyfayock