Skip to content

chore: Revert table-role and async-store move into component-toolkit (#242) - #250

Merged
gethinwebster merged 2 commits into
mainfrom
revert-table-role-async-store-242
Sep 11, 2026
Merged

chore: Revert table-role and async-store move into component-toolkit (#242)#250
gethinwebster merged 2 commits into
mainfrom
revert-table-role-async-store-242

Conversation

@gethinwebster

@gethinwebster gethinwebster commented Aug 19, 2026

Copy link
Copy Markdown
Member

Description

Removes the table-role and async-store internal primitives from component-toolkit (src/internal/table-role/, src/internal/async-store/, their package.json subpath exports, and the tsconfig.unit.json lib entry).

These primitives were duplicated here so a separate BasicTable repository could consume them from the toolkit. BasicTable now lives in cloudscape-design/components and imports these primitives directly from that repo, so the toolkit copies are unused.

Nothing in component-toolkit imports these modules, and the copies in cloudscape-design/components are unaffected.

Verification

  • npm run build — passes
  • npm run test:unit — 49 suites / 460 tests pass

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (aaa724d) to head (a15b8bb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   98.10%   99.03%   +0.92%     
==========================================
  Files          56       48       -8     
  Lines        1793     1343     -450     
  Branches      519      368     -151     
==========================================
- Hits         1759     1330     -429     
+ Misses         33       13      -20     
+ Partials        1        0       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gethinwebster
gethinwebster marked this pull request as ready for review September 11, 2026 07:47
@gethinwebster
gethinwebster requested a review from a team as a code owner September 11, 2026 07:47
@gethinwebster
gethinwebster requested review from amanabiy and removed request for a team September 11, 2026 07:47
@gethinwebster
gethinwebster added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit 74da7cc Sep 11, 2026
44 checks passed
@gethinwebster
gethinwebster deleted the revert-table-role-async-store-242 branch September 11, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants