chore: Stable tokens to cover keyframes - #4936
Merged
Merged
Conversation
pan-kot
force-pushed
the
chore-stable-token-versions-2
branch
from
August 26, 2026 10:33
9eda1de to
dbf89f6
Compare
pan-kot
commented
Aug 26, 2026
|
|
||
| function generateEnvironment() { | ||
| return task(`style-dictionary:environment`, () => { | ||
| const tokenStylesPath = join(workspace.sourcePath, './internal/styles/global.scss'); |
Member
Author
There was a problem hiding this comment.
This code generated tokenStylesSuffix as a hash from global.scss content. Instead, this token hash is deliberately made stable - so that the tokens across different versions are compatible.
pan-kot
commented
Aug 26, 2026
| @@ -1,25 +0,0 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
Author
There was a problem hiding this comment.
This is moved to /style-dictionary/utils
pan-kot
force-pushed
the
chore-stable-token-versions-2
branch
3 times, most recently
from
August 26, 2026 10:47
b499ed9 to
f430609
Compare
pan-kot
force-pushed
the
chore-stable-token-versions-2
branch
from
August 27, 2026 12:26
f14af98 to
b28a6f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 959 +1
Lines 31317 31342 +25
Branches 11565 11578 +13
=======================================
+ Hits 30585 30610 +25
+ Misses 725 686 -39
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
force-pushed
the
chore-stable-token-versions-2
branch
from
August 28, 2026 04:49
b28a6f2 to
5f46412
Compare
pan-kot
marked this pull request as ready for review
August 28, 2026 07:04
ywyyu17
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow-up for #4718
I also moved token versions to a different place so that it can be later imported by the internal build.
Depends on cloudscape-design/theming-core#201
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.