fix: Restore styles of jump-to-page input label - #4981
Conversation
49365b5 to
994f54b
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized, consistent with existing generated custom CSS property patterns, and correctly apply the new variable where pagination is rendered in header/container contexts.
Pull request overview
Restores the visual styling of the pagination “jump-to-page” inline label when pagination is rendered in non-default background contexts (e.g., table/card headers) by introducing an inheritable custom CSS property that drives the inline-label gradient background.
Changes:
- Introduces a new generated custom CSS property (
inlineLabelBackgroundColor) and uses it to control the top color stop of the inline-label gradient (enabled + disabled states). - Sets the inline-label background custom property in table header controls, cards header, and container variants so jump-to-page labels blend with their surrounding backgrounds.
- Replaces a hard-coded
emoffset in pagination jump-to-page input styles with a token-based spacing calculation and adds clarifying comments.
File summaries
| File | Description |
|---|---|
| src/table/styles.scss | Sets inlineLabelBackgroundColor for non-full-page table header controls to match the table header background. |
| src/pagination/styles.scss | Adjusts jump-to-page input vertical offset using design tokens; adds explanatory comments. |
| src/internal/styles/forms/mixins.scss | Updates inline-label and disabled inline-label gradient to use the new custom property with a fallback. |
| src/container/styles.scss | Sets inlineLabelBackgroundColor to container content background for default/stacked variants. |
| src/cards/styles.scss | Sets inlineLabelBackgroundColor for non-full-page cards header to match container header background. |
| build-tools/utils/custom-css-properties.js | Adds inlineLabelBackgroundColor to the generated custom CSS properties list. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 960 960
Lines 31366 31366
Branches 11589 11589
=======================================
Hits 30635 30635
Misses 724 724
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Before #4956, the jump-to-page feature of the pagination component was using an internal implementation of inline labels for the input component. That change introduced a small unintended change in the vertical positioning (the inline label+input were being shifted upwards on purpose).
This PR:
How has this been tested?
Manually compared against the
pagination/permutationspage against the state before #4956.The only noticeable change is in the inline label background, which is expected:
Before

After

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.