Skip to content

fix: Restore styles of jump-to-page input label - #4981

Merged
jperals merged 3 commits into
mainfrom
dev-v3-jotresse-fix-jump-to-page-label
Sep 8, 2026
Merged

fix: Restore styles of jump-to-page input label#4981
jperals merged 3 commits into
mainfrom
dev-v3-jotresse-fix-jump-to-page-label

Conversation

@jperals

@jperals jperals commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description

Before #4956, the jump-to-page feature of the pagination component was using an internal implementation of inline labels for the input component. That change introduced a small unintended change in the vertical positioning (the inline label+input were being shifted upwards on purpose).

This PR:

  • Restores the positioning of the label+input in the jump-to-page case
  • Improves how the background colors of inline labels works, by taking the background of the element it sits inside of (container, table header, or defaults to app layout content)

How has this been tested?

Manually compared against the pagination/permutations page against the state before #4956.

The only noticeable change is in the inline label background, which is expected:

Before
Screenshot 2026-09-08 at 15 15 53

After
Screenshot 2026-09-08 at 15 15 59

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals
jperals force-pushed the dev-v3-jotresse-fix-jump-to-page-label branch from 49365b5 to 994f54b Compare September 8, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are localized, consistent with existing generated custom CSS property patterns, and correctly apply the new variable where pagination is rendered in header/container contexts.

Pull request overview

Restores the visual styling of the pagination “jump-to-page” inline label when pagination is rendered in non-default background contexts (e.g., table/card headers) by introducing an inheritable custom CSS property that drives the inline-label gradient background.

Changes:

  • Introduces a new generated custom CSS property (inlineLabelBackgroundColor) and uses it to control the top color stop of the inline-label gradient (enabled + disabled states).
  • Sets the inline-label background custom property in table header controls, cards header, and container variants so jump-to-page labels blend with their surrounding backgrounds.
  • Replaces a hard-coded em offset in pagination jump-to-page input styles with a token-based spacing calculation and adds clarifying comments.
File summaries
File Description
src/table/styles.scss Sets inlineLabelBackgroundColor for non-full-page table header controls to match the table header background.
src/pagination/styles.scss Adjusts jump-to-page input vertical offset using design tokens; adds explanatory comments.
src/internal/styles/forms/mixins.scss Updates inline-label and disabled inline-label gradient to use the new custom property with a fallback.
src/container/styles.scss Sets inlineLabelBackgroundColor to container content background for default/stacked variants.
src/cards/styles.scss Sets inlineLabelBackgroundColor for non-full-page cards header to match container header background.
build-tools/utils/custom-css-properties.js Adds inlineLabelBackgroundColor to the generated custom CSS properties list.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jperals
jperals marked this pull request as ready for review September 8, 2026 13:36
@jperals
jperals requested a review from a team as a code owner September 8, 2026 13:36
@jperals
jperals requested review from pan-kot and removed request for a team September 8, 2026 13:36
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (b00de96) to head (cf62e46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4981   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         960      960           
  Lines       31366    31366           
  Branches    11589    11589           
=======================================
  Hits        30635    30635           
  Misses        724      724           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals
jperals enabled auto-merge September 8, 2026 14:02
@jperals
jperals added this pull request to the merge queue Sep 8, 2026
Merged via the queue into main with commit 74e4f3d Sep 8, 2026
68 checks passed
@jperals
jperals deleted the dev-v3-jotresse-fix-jump-to-page-label branch September 8, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants