Skip to content

feat: Version-based token hashes - #190

Merged
pan-kot merged 1 commit into
mainfrom
feat/stable-theme-hashing
Jul 15, 2026
Merged

pan-kot merged 1 commit into
mainfrom
feat/stable-theme-hashing

Conversation

@pan-kot

@pan-kot pan-kot commented Jul 14, 2026 •

Copy link
Copy Markdown
Member

Introducing an alternative way of computing design token hashes. This takes an explicit version, declared per token instead of token's value - allowing the hash to persist even if the value changes, thus giving us granular control over such changes. The idea is to make token hashes stable across a wide range of component versions to make theming simpler.

This is a part of theming improvements project, see QUIP [XEEHAl8Q4kbb].

Once merged, it will be adopted in the components repository. Eventually, all tokens will be migrated over to use a single shared version, but in order to minimise risks - we will migrate tokens in batches. See the first one: cloudscape-design/components#4718

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (9e1e5d4) to head (d2065ea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          55       55           
  Lines        1440     1443    +3     
  Branches      264      265    +1     
=======================================
+ Hits         1400     1403    +3     
  Misses         34       34           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot
pan-kot marked this pull request as ready for review July 15, 2026 05:40
@pan-kot
pan-kot requested a review from a team as a code owner July 15, 2026 05:40
@pan-kot
pan-kot requested review from amanabiy and removed request for a team July 15, 2026 05:40

@amanabiy amanabiy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pan-kot
pan-kot added this pull request to the merge queue Jul 15, 2026
Merged via the queue into main with commit f8ab78d Jul 15, 2026
45 checks passed
@pan-kot
pan-kot deleted the feat/stable-theme-hashing branch July 15, 2026 16:15
pan-kot added a commit that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants