feat: Version-based token hashes - #190
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 55 55
Lines 1440 1443 +3
Branches 264 265 +1
=======================================
+ Hits 1400 1403 +3
Misses 34 34
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing an alternative way of computing design token hashes. This takes an explicit version, declared per token instead of token's value - allowing the hash to persist even if the value changes, thus giving us granular control over such changes. The idea is to make token hashes stable across a wide range of component versions to make theming simpler.
This is a part of theming improvements project, see QUIP [XEEHAl8Q4kbb].
Once merged, it will be adopted in the components repository. Eventually, all tokens will be migrated over to use a single shared version, but in order to minimise risks - we will migrate tokens in batches. See the first one: cloudscape-design/components#4718
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.