EXP-2414: Remove client-facing Accounting API reference - #1889
pmckinney-codat wants to merge 5 commits into
Conversation
The Accounting API reference at /accounting-api was unlisted but still publicly served, and a client found it via the URL. An auth-walled internal copy now lives at accounting-api-ref.codat.ai, so the client-facing page and its OAS spec can go. - Delete the /accounting-api reference page and Codat-Accounting.json - Remove the accounting-api sidebar config (unused since its doc pages were removed; the require was already commented out) - Redirect /accounting-api to /lending-api, which documents the same properties, so existing deep links don't 404 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Drop the /accounting-api -> /lending-api redirect: the URL should be completely dead, not forward anywhere. That means the ~60 internal doc links into the old reference would 404, so rewrite them to the product references that still document the same endpoints and models: - Reads (schemas, list/get endpoints) -> Lending API reference, which documents the same accounting data (per the Slack thread) - Bank transaction writes in bank-feeds docs -> Bank Feeds API - Bill Pay use case guides and other writes -> Sync for Payables API - Tax rate schemas -> Sync for Payables (Lending has no TaxRate schema) - De-link the few with no surviving equivalent (Items schema, delete-journal-entry, the Accounting API entries in historical blog posts and the using-the-api overview nav list) Every new target was verified against the specs in static/oas. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
vale
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('be supported').
📝 [vale] <Google.Will> reported by reviewdog 🐶
Avoid using 'will'.
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('being made').
📝 [vale] <Google.Parens> reported by reviewdog 🐶
Use parentheses judiciously.
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('be retrieved').
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('is set').
codat-docs/docs/usecases/bill-pay/payments.md
Line 294 in 78a2940
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('is required').
codat-docs/docs/usecases/bill-pay/payments.md
Line 294 in 78a2940
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('be retrieved').
codat-docs/docs/usecases/bill-pay/payments.md
Line 340 in 78a2940
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('be retrieved').
codat-docs/docs/usecases/bill-pay/payments.md
Line 863 in 78a2940
📝 [vale] <Google.Passive> reported by reviewdog 🐶
In general, use active voice instead of passive voice ('are sorted').
The two blog posts are historical announcements and should read as published. Restore their original wording and link targets; the only edit kept is making the one relative /accounting-api link absolute (same destination), because the CI link checker skips absolute docs.codat.io URLs but would fail every future PR on a relative link to the now-removed page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
From the product review of the new link destinations: - expenses/config-and-categorize: point the account-mapping step at the Sync for Expenses options endpoint (get-create-chartOfAccounts-model) instead of the Lending list-accounts read - qbo-bank-feeds docs and the banking proxy example: drop the three links into the Lending reference entirely (bank feeds/banking readers will not have Lending); text kept Commerce prerequisites page feedback is pending a scope decision. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Product review feedback (Hawi): the page was already dropped from the sync-for-commerce sidebar and its parent build guide is gone, so it should have been removed then. It was only reachable by URL, nothing links to it, and no redirect targets it, so it can go outright -- which also removes four of the relinked accounting data-type links. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Link check results: |
| | `errorMessage` | | Codat standardizes error messages for the status codes. Error messages returned in the redirect will always be mapped with the status codes listed above. <br/> **403** = "User cancelled." <br/> **500** = "Unknown error occurred." <br/> **501** = "Not supported." <br/> **Note**: If you want to use the original error message from the integration, use `statusText`. | | ||
| | `statusText` | _String_ | String as it's passed back from the integration. | | ||
| | `data.company.companyName` | _String_ | The name of the connected party within the underlying platform. <br/>This maps to the company name property in the [company info dataset](/accounting-api#/schemas/CompanyDataset). | | ||
| | `data.company.companyName` | _String_ | The name of the connected party within the underlying platform. <br/>This maps to the company name property in the [company info dataset](/lending-api#/schemas/AccountingCompanyInfo). | |
There was a problem hiding this comment.
Hawi confirmed this was correct (or as correct as it can be)
What
Removes the client-facing Accounting API reference from docs.codat.io —
/accounting-apibecomes a hard 404, no redirect:/accounting-apireference page (src/pages/accounting-api/index.tsx)static/oas/Codat-Accounting.json)sidebars/accounting-api.jsconfig (its require insidebars.jswas already commented out and the doc pages it references were removed long ago)/accounting-api#/…to the product references that still document the same endpoints and models:Every new link target was verified against the specs in
static/oas. The pre-existing redirects for the long-removed doc pages (/accounting-api/overview→/using-the-api/overviewetc.) are untouched — they point at unrelated live pages.Notes on /updates
The two legacy announcements under
/updates(Apr and Sep 2023) that reference the old page are left as published — we don't edit historical announcements. The only touch is making the one relative link in the Sep 2023 post absolute (same destination): the CI link checker skips absolute docs.codat.io URLs but would fail every future PR on a relative link to the removed page.Why
The reference was unlisted but still publicly served, and a client found it via the URL. Tom confirmed the Lending API reference documents the same properties, so anyone who needs it (Lloyds, Amex) can be pointed there. An auth-walled internal copy lives at accounting-api-ref.codat.ai for emergencies.
Verification
npm run buildpasses locally: no page or redirect stub is emitted at/accounting-api,Codat-Accounting.jsonis absent from the build output, and no built page links to/accounting-api. Prettier and cspell pass on all touched files. The CI link check on this PR reported zero broken links.🤖 Generated with Claude Code