Plexus Eclipse Compiler depends on Plexus Testing with 'compile' scope

[kriegaex]

I just noticed this by chance when running mvn dependency:tree -Dscope=compile on the project, actually looking for Sisu Inject dependencies because of #347. Before I forget about it, let me create this issue.

------------< org.codehaus.plexus:plexus-compiler-eclipse >-------------
Building Plexus Eclipse Compiler 2.14.3-SNAPSHOT                  [8/11]
  from plexus-compilers\plexus-compiler-eclipse\pom.xml
--------------------------------[ jar ]---------------------------------

--- dependency:3.6.1:tree (default-cli) @ plexus-compiler-eclipse ---
org.codehaus.plexus:plexus-compiler-eclipse:jar:2.14.3-SNAPSHOT
+- org.codehaus.plexus:plexus-compiler-api:jar:2.14.3-SNAPSHOT:compile
|  \- org.slf4j:slf4j-api:jar:1.7.36:compile
+- org.codehaus.plexus:plexus-utils:jar:4.0.0:compile
+- org.eclipse.jdt:ecj:jar:3.36.0:compile
+- javax.inject:javax.inject:jar:1:compile
\- org.codehaus.plexus:plexus-testing:jar:1.3.0:compile
   +- org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.9.0.M2:compile
   |  +- javax.annotation:javax.annotation-api:jar:1.2:compile
   |  +- javax.enterprise:cdi-api:jar:1.2:compile
   |  +- org.codehaus.plexus:plexus-component-annotations:jar:2.2.0:compile
   |  \- org.codehaus.plexus:plexus-classworlds:jar:2.6.0:compile
   +- org.eclipse.sisu:org.eclipse.sisu.inject:jar:0.9.0.M2:compile
   \- com.google.inject:guice:jar:6.0.0:compile
      +- jakarta.inject:jakarta.inject-api:jar:2.0.1:compile
      +- aopalliance:aopalliance:jar:1.0:compile
      \- com.google.guava:guava:jar:33.0.0-jre:compile
         +- com.google.guava:failureaccess:jar:1.0.2:compile
         +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
         +- com.google.code.findbugs:jsr305:jar:3.0.2:compile
         +- org.checkerframework:checker-qual:jar:3.41.0:compile
         +- com.google.errorprone:error_prone_annotations:jar:2.23.0:compile
         \- com.google.j2objc:j2objc-annotations:jar:2.8:compile

plexus-compiler/plexus-compilers/plexus-compiler-eclipse/pom.xml

Lines 53 to 57 in c5edddc

	<dependency>
	<groupId>org.codehaus.plexus</groupId>
	<artifactId>plexus-testing</artifactId>
	<scope>compile</scope>
	</dependency>

I think, this should be fixed. If anything breaks when changing the scope to compile, it means that transitive dependencies of plexus-testing are used and should be declared explicitly.

BTW, mvn dependency:analyze -Dscope=compile says:

Used undeclared dependencies found:
   org.slf4j:slf4j-api:jar:1.7.36:compile
Non-test scoped test only dependencies found:
   org.codehaus.plexus:plexus-testing:jar:1.3.0:compile

It might be worth looking at dependency:analyze results for all modules. There seem to be a few used undeclared dependencies.