fix: make MariaDB version detection case-insensitive in tests#10208
Open
jalexiscv wants to merge 1 commit into
Open
fix: make MariaDB version detection case-insensitive in tests#10208jalexiscv wants to merge 1 commit into
jalexiscv wants to merge 1 commit into
Conversation
Fixes codeigniter4#7929 The tests used str_contains() for MariaDB version detection, which is case-sensitive. On some MariaDB installations, the version string returned by server_info may have different casing, causing the detection to fail. Also updated GetVersionTest regex to accept MariaDB version format '10.11.4-MariaDB-1' which includes a suffix after the numeric version. Changes: - ForgeTest: str_contains → str_contains(strtolower(...)) - GetFieldDataTestCase: str_contains → str_contains(strtolower(...)) - GetVersionTest: regex updated to match MariaDB version format Ref: codeigniter4#7929
|
Hi there, jalexiscv! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work Sincerely, the mergeable bot 🤖 |
neznaika0
suggested changes
May 18, 2026
| return ! ( | ||
| version_compare($this->db->getVersion(), '8.0.17', '>=') | ||
| && ! str_contains($this->db->getVersion(), 'MariaDB') | ||
| && ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB')) |
Contributor
There was a problem hiding this comment.
No need to convert the string, edit as mariadb
| ]; | ||
|
|
||
| if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains($this->db->getVersion(), 'MariaDB')) { | ||
| if (version_compare($this->db->getVersion(), '8.0.17', '>=') && ! str_contains(strtolower($this->db->getVersion()), strtolower('MariaDB'))) { |
Contributor
There was a problem hiding this comment.
No need to convert the string, edit as mariadb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7929 - [MariaDB] phpunit test errors
Problem
Two test failures on MariaDB:
ForgeTest::testAddFields - Uses str_contains() for MariaDB version detection which is case-sensitive. On some MariaDB installations, the server_info version string may have different casing, causing MariaDB to be incorrectly treated as MySQL 8.0.17+, which sets max_length to null for integer fields. MariaDB still reports max_length for integer columns.
GetVersionTest::testGetVersion - The regex only matches plain numeric versions like 8.0.17, not MariaDB versions like 10.11.4-MariaDB-1.
Solution
ForgeTest + GetFieldDataTestCase
Replace str_contains($version, 'MariaDB') with case-insensitive comparison using strtolower()
GetVersionTest
Update the regex to accept versions with suffixes.
Changes
Ref: #7929
Closes #7929