chore: update psalm to 5.0#6931
Merged
Merged
Conversation
I don't know why ERROR.
kenjis
force-pushed
the
update-psalm-5.0
branch
from
14ce252 to
7483823
Compare
paulbalandan
approved these changes
Dec 2, 2022
| * $cookie2->getName(); // prod_cookie | ||
| * ``` | ||
| * | ||
| * @template-implements ArrayAccess<string, bool|int|string> |
Member
There was a problem hiding this comment.
This is generic typing. If we want to impose this too for phpstan, we may consider raising phpstan level to 6.
Member
There was a problem hiding this comment.
5 to 6 is hard for existing code bases. I would of course love to see our level increase, so maybe we can baseline existing array issues and make the move.
MGatner
approved these changes
Dec 2, 2022
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
Please consider updating DevKit to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/vimeo/psalm/releases/tag/5.0.0
Checklist: