Skip to content

Update nexusphp/tachycardia to ^1.3#113

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:update-nexusphp/tachycardia
Sep 7, 2023
Merged

Update nexusphp/tachycardia to ^1.3#113
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:update-nexusphp/tachycardia

Conversation

@kenjis

@kenjis kenjis commented Sep 7, 2023

Copy link
Copy Markdown
Member

Expeditable trait was introduced in v1.3.0.
codeigniter4/settings use it.

See codeigniter4/settings#95

phpunit / PHP 7.4 - MySQLi - lowest

...

Run vendor/bin/phpunit --verbose --coverage-text --testsuite main
PHP Fatal error:  Trait 'Nexus\PHPUnit\Extension\Expeditable' not found in /home/runner/work/settings/settings/tests/_support/TestCase.php on line 11

Fatal error: Trait 'Nexus\PHPUnit\Extension\Expeditable' not found in /home/runner/work/settings/settings/tests/_support/TestCase.php on line 11
Error: Process completed with exit code 255.

https://github.com/codeigniter4/settings/actions/runs/6104148667/job/16565731540?pr=95

Expeditable trait was introduced in v1.3.0.
codeigniter4/settings use it.
@kenjis kenjis requested a review from paulbalandan September 7, 2023 01:36
@paulbalandan

Copy link
Copy Markdown
Member

I don't understand why ^1.0 is not working. Surely there is no composer.lock in settings, right?

@kenjis

kenjis commented Sep 7, 2023

Copy link
Copy Markdown
Member Author

@paulbalandan

Copy link
Copy Markdown
Member

Ah, I see.

@kenjis kenjis merged commit e27011b into codeigniter4:develop Sep 7, 2023
@kenjis kenjis deleted the update-nexusphp/tachycardia branch September 7, 2023 03:02
@MGatner

MGatner commented Sep 9, 2023

Copy link
Copy Markdown
Member

Why are we checking the lowest version? For maximum backwards-comparability?

@MGatner

MGatner commented Sep 9, 2023

Copy link
Copy Markdown
Member

And, are we?

strategies:
...
  matrix:
    dependencies: ['highest']

@kenjis

kenjis commented Sep 9, 2023

Copy link
Copy Markdown
Member Author

Why are we checking the lowest version? For maximum backwards-comparability?

Yes. The lowest version can be installable if a user specifies.
So if it does not work, we should update the lowest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants