Skip to content

Fix a styling issue on iOS/iPadOs - #2248

Closed
jw-12138 wants to merge 2 commits into
coder:v3.6.1from
jw-12138:v3.6.1
Closed

Fix a styling issue on iOS/iPadOs#2248
jw-12138 wants to merge 2 commits into
coder:v3.6.1from
jw-12138:v3.6.1

Conversation

@jw-12138

Copy link
Copy Markdown
Contributor

Related issue: #2247

So, instead of using button elements( including input[type="submit"]) directly on page, I added a label element which preserved the style while remaining the same functionality.

Before

image

After

image

Over all, not a big problem but still, an improvement.

@nhooyr

nhooyr commented Nov 19, 2020

Copy link
Copy Markdown
Contributor

Hi @jw-12138, thanks for reporting this bug and contributing. ❤️

I've opened #2339 with your commit included for credits and a simpler fix applied where we just disable webkit's native input styles.

@nhooyr nhooyr closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants