[rsoaresd]

Description

Update dependencies

Tool/Library	Current Version	Updates to Version
Operator SDK	1.38	1.39.2
k8s.io/*	v0.30.1	v0.31.2
controller-runtime	v0.18.4	v0.19.7
controller-tools	v0.15.0	v0.16.5

Issue ticket number and link

SANDBOX-955

[rsoaresd]

Due to this change in sigs.k8s.io/controller-runtime (introduced in v0.19.0), we need to skip the name validation to avoid this error:

{"level":"error","ts":"2025-04-22T10:46:41.577Z","logger":"setup","msg":"unable to create controller","controller":"ToolchainCluster","error":"controller with name toolchaincluster already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric","stacktrace":"main.main\n\t/Users/rsoaresd/member-operator/cmd/main.go:245\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:271"}

[alexeykazakov]

Hm... so we are using the same name for different controllers? Can it cause any issues? Basically do we have to hide this error or actually fix it, if it's an actual error?

[fbm3307]

+1
Can be done as separate PR

[rsoaresd]

From what I saw in the error:

controller with name usersignup already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric

Addressed the change here: 9fc8c96

[MatousJobanek]

Thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,metlos,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (6138153) to head (c12019e).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...usersignupcleanup/usersignup_cleanup_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          82       82           
  Lines        7926     7927    +1     
=======================================
+ Hits         6623     6624    +1     
  Misses       1102     1102           
  Partials      201      201           

Files with missing lines	Coverage Δ
...usersignupcleanup/usersignup_cleanup_controller.go	76.02% <0.00%> (-0.45%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.