Skip to content

Add explicit hightlight styling - #45

Merged
metlos merged 1 commit into
codeready-toolchain:masterfrom
metlos:highlight-styling
Oct 15, 2026
Merged

metlos merged 1 commit into
codeready-toolchain:masterfrom
metlos:highlight-styling

Conversation

@metlos

@metlos metlos commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Add explicit hightlight styling to prevent inheriting non-fitting styles from elsewhere in the console.

Assisted-by: GPT

Summary by CodeRabbit

  • Style
    • Updated code syntax highlighting in interactive labs to use colors suited to light and dark themes.
    • Bold and italic formatting remains visible in highlighted code.

non-fitting styles from elsewhere in the console.

Assisted-by: GPT
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 5c2f4580-9166-4027-8320-5e36a14c44dd
📥 Commits

Reviewing files that changed from the base of the PR and between 6e46f36 and 1b68f45.

📒 Files selected for processing: 2
  • frontend/src/interactive-labs.css
  • frontend/src/interactive-labs.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

⏰ Context from checks skipped due to timeout: 3
  • GitHub Check: Test
  • GitHub Check: Build Image
  • GitHub Check: Lint
🧰 Additional context used
📓 Path-based instructions: 1
-Focus on major issues impacting performance, readability, maintainability and security.

⚙️ CodeRabbit configuration file

Files:

  • frontend/src/interactive-labs.test.ts
  • frontend/src/interactive-labs.css
🪛 ast-grep (0.45.3)
frontend/src/interactive-labs.test.ts

[warning] 2-2: Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { execFileSync } from "node:child_process";
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(detect-child-process-typescript)

🔇 Additional comments: 2
frontend/src/interactive-labs.css: 1

58-64: LGTM!

Also applies to: 109-114, 615-668

frontend/src/interactive-labs.test.ts: 1

1-118: LGTM!

Walkthrough

The change adds syntax-token color palettes for light and dark themes, applies highlight.js styles within interactive-labs documentation content, and adds Chromium tests for theme styles and caller overrides.

Changes

Interactive Labs syntax highlighting

Layer / File(s) Summary
Theme palettes and scoped styles
frontend/src/interactive-labs.css
Adds syntax-token colors for light and dark themes. Adds documentation-scoped highlight.js rules for code blocks, token colors, substitutions, and emphasis.
Browser style validation
frontend/src/interactive-labs.test.ts
Adds Chromium tests for light, PF5 dark, and PF6 dark themes. Tests token contrast, caller overrides, nested token styles, and unwrapped host styles.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: bug, test

Suggested reviewers: xcoulon

Merge Risk: ⚪ Minimal · up to 1b68f

No concrete merge-blocking issue is established. The browser style checks run when Chromium is available.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding explicit highlight styling to prevent inherited console styles. It is concise, but it contains a spelling error in "hightlight."
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added bug Something isn't working test labels Oct 15, 2026
@metlos
metlos merged commit 1c833d4 into codeready-toolchain:master Oct 15, 2026
4 checks passed
@metlos
metlos deleted the highlight-styling branch October 19, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants