[ankuagarwal]

Description

• Add data_domain_external_id as part of transformation create/update request & response object
• Add data_domain_external_ids as part of list/filter calls for transformations.

Checklist:

• Tests added/updated.
• Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
  If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
• The PR title follows the Conventional Commit spec.

[gemini-code-assist]

Code Review

This pull request introduces support for filtering and managing transformations by data_domain_external_id across the sync and async APIs, data classes, and filters. Feedback on the changes highlights a few issues: incorrect imports and fixture names (pytest_httpx2 and httpx2_mock) in the unit tests, redundant manual tests for load/dump/update methods that violate the style guide, and a recommendation to use keyword arguments instead of positional arguments in TransformationWrite.copy() for improved maintainability.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (0a86981) to head (cc7b45c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
- Coverage   93.58%   93.58%   -0.01%     
==========================================
  Files         533      534       +1     
  Lines       56210    56247      +37     
==========================================
+ Hits        52602    52636      +34     
- Misses       3608     3611       +3     

Files with missing lines	Coverage Δ
cognite/client/_api/transformations/__init__.py	75.92% <100.00%> (+0.22%)	⬆️
...gnite/client/_sync_api/transformations/__init__.py	94.64% <ø> (ø)
...te/client/data_classes/transformations/__init__.py	88.15% <100.00%> (+2.38%)	⬆️
tests/tests_unit/test_api/test_transformations.py	100.00% <100.00%> (ø)
...lasses/test_transformations/test_transformation.py	100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[MoonWorm]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for filtering and managing transformations by data_domain_external_id (and data_domain_external_ids for filtering) across the sync and async clients, data classes, and updates. The review feedback highlights critical typos in the unit tests, specifically importing pytest_httpx2 instead of pytest_httpx and using httpx2_mock instead of httpx_mock, which will break the test suite. Additionally, it is recommended to refactor TransformationWrite.copy() to use keyword arguments instead of positional arguments to improve maintainability and align with existing patterns.

[MoonWorm]

Transformation APIs already has this implemented and deployed, right?

[haakonvt]

🦄