This repository was archived by the owner on Aug 23, 2026. It is now read-only.
Repository navigation
Basic model to calculate expiry times - #1
Merged
Merged
Conversation
D4nte
reviewed
Mar 5, 2019
D4nte
left a comment
D4nte
left a comment
Contributor
There was a problem hiding this comment.
Will have to re-read the maths later.
luckysori
commented
Mar 5, 2019
luckysori
commented
Mar 5, 2019
added 2 commits
March 6, 2019 11:32
Co-Authored-By: luckysori <lucas.soriano@tenx.tech>
thomaseizinger
left a comment
thomaseizinger
left a comment
Contributor
There was a problem hiding this comment.
I am seriously impressed by your work guys!
Very nicely done :)
luckysori
commented
Mar 6, 2019
LLFourn
reviewed
Mar 6, 2019
LLFourn
reviewed
Mar 6, 2019
LLFourn
reviewed
Mar 6, 2019
LLFourn
reviewed
Mar 6, 2019
bonomat
reviewed
Mar 6, 2019
bonomat
left a comment
bonomat
left a comment
Member
There was a problem hiding this comment.
Good job on this model. I have a few comments but let's discuss it offline.
bonomat
reviewed
Mar 7, 2019
luckysori
commented
Mar 10, 2019
|
|
Contributor
|
Is this PR still valid? didn't @LLFourn moved the spike result somewhere else? Please clarify. |
Collaborator
|
@D4nte The spike references the overleaf so yes. Please approve. |
thomaseizinger
approved these changes
Apr 10, 2019
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves comit-network/RFCs#14.
The actual model was moved to overleaf because it's easier to write math: https://www.overleaf.com/read/sswbyytnfjhy
DM @luckysori or @LLFourn for editable link.
Note that we don't now have actual code to calculate times from the model. This will be done this quarter in a follow up task.