Repository navigation
Deploy a release by moving it, and stop on a full disk² - #233
Merged
Merged
Conversation
Staging moved from /tmp to disk in #218, and the deploy step still copied the unpacked release into its target, so it was on disk twice. LibreNMS on its 4 GB disk ran out of space in 41 installs within four days. The tarball mode ignored cp's failure and returned 0, so the install went on with a partial tree and only failed when it could not write the version file. Entries the target does not have yet are now moved, the rest copied over and removed from staging. A failed deploy on a full disk says so and returns 252.
michelroegl-brunner
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Staging moved from /tmp to disk in #218, and the deploy step still copied the unpacked release into its target, so it was on disk twice. LibreNMS on its 4 GB disk ran out of space in 41 installs within four days. The tarball mode ignored cp's failure and returned 0, so the install went on with a partial tree and only failed when it could not write the version file.
Entries the target does not have yet are now moved, the rest copied over and removed from staging. A failed deploy on a full disk says so and returns 252.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)