-
Notifications
You must be signed in to change notification settings - Fork 52
feat: Add Cross-Space Reference Resolution Support #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rafal Niski (rafalniski)
merged 6 commits into
master
from
feat/JAVA-306-cross-space-resulution
Nov 14, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
23ec7dd
Add support for cross space resolution
rafalniski a8e8732
Checkstyle issues
rafalniski 421776d
Checkstyle issues
rafalniski b93ccd1
Resoruce factory error fix
rafalniski 2154844
Update major value
rafalniski f081ac5
Remove test
rafalniski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,12 @@ static SynchronizedSpace nextSpace(SynchronizedSpace space, CDAClient client) { | |
| static void resolveLinks(ArrayResource array, CDAClient client) { | ||
| for (CDAEntry entry : array.entries().values()) { | ||
| ensureContentType(entry, client); | ||
| for (CDAField field : entry.contentType().fields()) { | ||
| CDAContentType contentType = entry.contentType(); | ||
| if (contentType == null || contentType.fields() == null) { | ||
| // Content type may be null for cross-space entries | ||
| continue; | ||
| } | ||
| for (CDAField field : contentType.fields()) { | ||
| if (field.linkType() != null) { | ||
| resolveSingleLink(entry, field, array); | ||
| } else if ("Array".equals(field.type) && "Link".equals(field.items().get("type"))) { | ||
|
|
@@ -88,13 +93,19 @@ public static void ensureContentType(CDAEntry entry, CDAClient client) { | |
| } | ||
|
|
||
| String contentTypeId = extractNested(entry.attrs(), "contentType", "sys", "id"); | ||
| if (contentTypeId == null) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| contentType = client.cacheTypeWithId(contentTypeId).blockingFirst(); | ||
| entry.setContentType(contentType); | ||
| } catch (CDAResourceNotFoundException e) { | ||
| if (client.hasCrossSpaceTokens) { | ||
| return; | ||
| } | ||
|
Comment on lines
+104
to
+106
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I get what's going on here. if the client isn't able to cache the type, it's likely it's because that type is in a different space. OTOH, it could be a race and the type was removed, which would be a valid error. dunno if you have a good way to sort between the two. thanks! |
||
| throw new CDAContentTypeNotFoundException(entry.id(), CDAEntry.class, contentTypeId, e); | ||
| } | ||
|
|
||
| entry.setContentType(contentType); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have actual cross-space requests been tested using this new interceptor? I had been able to add an interceptor by creating my own
OkHttpClient, but when I would run the code, I'd get errors like:noting that
myContentTypeexists in the remote space but not in the one directly being queriedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was an issue with the resource factory, thanks for catching it!