fix(requestflag): inspect underlying type in PostParse for empty string and bool env var handling - #35
Open
Adityakk9031 wants to merge 1 commit into
Conversation
…ng and bool env var handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
internal/requestflag/requestflag.go(Flag[T].PostParse), when handling environment variable sources, the code previously checked:reflect.TypeOf(f.value).Kind() == reflect.Stringreflect.TypeOf(f.value).Kind() == reflect.BoolBecause
f.valueis of concrete type*cliValue[T],reflect.TypeOf(f.value).Kind()always returnsreflect.Pointer, neverreflect.Stringorreflect.Bool.This caused two bugs:
""),val != ""evaluated to false, and the string check failed, so the flag was never populated from the environment variable."", the bool check failed, andf.Set(f.Name, "false")was never executed.Solution
Inspect the underlying type parameter
Tand flag metadata usingreflect.TypeFor[T]()andf.IsBoolFlag().Tests
TestFlagPostParse_EnvVarsininternal/requestflag/requestflag_test.goverifying that both string flags and boolean flags correctly parse empty string environment variables duringPostParse.