feat(security): limit request body size - #659
Open
oxura wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #341.
Request bodies are currently unbounded at the project boundary. An upload or chunked request can therefore keep growing until the process runs out of memory.
This adds a global 2 MiB default and a
max_request_body_sizeTOML setting for projects that need a different ceiling. Every incoming body is wrapped before it reaches routing or middleware, and the limit counts bytes across the full stream rather than trusting Content-Length.When the limit is crossed, the body returns a Cot error with HTTP 413. The error keeps the normal project error path intact, so production uses the configured error handler; in debug diagnostics the message points directly at
max_request_body_size. Existing body errors also keep their original Cot status instead of being flattened into a 400 while crossing the wrapper.Coverage includes the exact boundary, a multi-chunk overflow, TOML/default configuration, and an end-to-end project test proving a custom error handler receives and returns the 413.
Checked with:
cargo test -p cot_core body::tests(8 passed)cargo test -p cot --all-features request_body_limit(2 passed)cargo clippy -p cot_core -p cot --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --check