chore: verification gate (Node 22.18, CI, typecheck/lint, consumer-rules) - #23
Merged
Merged
Conversation
Pin the package Node floor at >=22.18, ship Autolink consumer ProGuard keep rules, and add a CI workflow that runs unit tests, typecheck, lint, and Linux native `make test`. Clear typecheck by stubbing connectors and typed NativeModules/Response harnesses instead of invalid casts. Co-authored-by: 達達 <djwok@users.noreply.github.com>
djwok
marked this pull request as ready for review
September 9, 2026 08:49
This was referenced Sep 9, 2026
This was referenced Sep 9, 2026
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FM-PS-LYNX-008 item H (Verification gate) only — not A/E/B/C/D/F/G.
What landed
package.jsonengines,.nvmrc). Docs and exampleenginesaligned.pnpm typecheckgreen: connector stubs includeuploadData; stream tests use a typed NativeModules/Response harness instead of invalidas Response/as NativeModulesHostcasts.pnpm lintgreen: SAFETY-freeNativeModuleslookup, named Lynx globals (__globalProps, event emitter), type-predicate helpers.LynxRemote.tsremains ignored for anti-slop (PrimJS stream probes; not a SyncStreamTransport rewrite).android/consumer-rules.prokeep rules forLynxLibraryProviderImplandNativePowerSyncModule..github/workflows/ci.yml) runspnpm test,pnpm typecheck,pnpm lint, andmake teston Ubuntu with pnpm frompackageManager(pnpm@12.3.4) and Node from.nvmrc.release.ymlis unchanged.Issue #18 comment (paste if Issues API 403s)
H (Verification gate) landed in this PR: Node >=22.18 pin, typecheck/lint green, Autolink
consumer-rules.pro, and a CI workflow that runs JS tests plus Linuxmake test. Architecture items A/E/B/C/D/F/G are not in this PR.Fixes nothing in production architecture. Tracking: #18