FM-PS-LYNX-014 T3: replace callNative overloads with NativeSql - #41
Merged
Merged
Conversation
Map NativePowerSyncModule to a nativeSql object of promise functions built on withNativeCallback. Drops the four overloads, switch, and SAFETY casts. ADR-0001 callback wire is unchanged. Co-authored-by: 達達 <djwok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements T3 only of FM-PS-LYNX-014 / #34 on current
main.Replaces the four
callNativeoverloads + switch +SAFETYcasts with onenativeSqlvalue: promise-returning functions derived fromNativePowerSyncModule, each built onwithNativeCallback. ADR-0001 public SQL RPC wire (callbackopen/close/execute/executeBatch) is unchanged. Fake Native Module tests still drive the callback module.Resulting interface
Callers:
LynxConnection(execute/executeBatch/close) andLynxDBAdapter.openConnection(open).Deleted
callNativeoverloads + implementation signatureswitch (method)dispatcherSAFETYcasts (as OpenPayload,as string,as BindValues,as BindValueRows)Untouched: PowerSyncDatabase, HTTP transport, NativeSyncHttp, host helper, native Android/iOS, policy/UTF-8/build.
Tests
nativeSql.*NativePowerSyncModulethrowsVerification
pnpm typecheck,pnpm lint, andpnpm test(108 passing) are green on this revision.Paste-ready note for #34
Could not comment on #34 from this environment (issue API 403 / not resolvable). Paste:
Closes the T3 slice of #34 only.