Repository navigation
preview: mirror fork PR #7718 - #7722
Closed
github-actions[bot] wants to merge 2 commits into
Closed
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…modal Two issues on the Account modal's "Unfillable" warning when the user opened "Edit partial approval": 1. The amount preview at the top of the modal pulled from `useDerivedTradeState()`, which reflects the *current* trade form, not the pending order being warned about. With another (e.g. limit) order draft on the form, the preview showed the wrong sell/buy amounts. 2. The token symbol could wrap mid-line in the "Please top up X balance" copy. Thread the order's `outputAmount` from `ActivityDetails` down through `OrderFillabilityWarning` -> `OrderPartialApprove` -> `PartialApproveAmountModal` -> `ChangeApproveAmountModal` / `ChangeApproveAmountModalPure` to `SwapAmountPreview`, which now accepts explicit `inputCurrencyAmount` / `outputCurrencyAmount` overrides and only falls back to the derived trade state when none are provided. Wrap the token symbol in the not-enough-balance copy in a `NoWrap` span so it stays on a single line. Closes #7686
Deploying explorer-dev with
|
| Latest commit: |
bc520d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05af24c2.explorer-dev-dxz.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7718.explorer-dev-dxz.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying swap-dev with
|
| Latest commit: |
bc520d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://38ec545d.swap-dev-5u6.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7718.swap-dev-5u6.pages.dev |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors fork PR #7718 for Cloudflare Pages preview builds.
Source PR: #7718
Source fork branch:
tenderdeve/cowswap:fix/7686-unfillable-allowance-widget-uiMirrored SHA:
bc520d2d15c3Do not merge this PR. Close the source PR to clean up this mirror.