Skip to content

preview: mirror fork PR #7718 - #7722

Closed
github-actions[bot] wants to merge 2 commits into
developfrom
cf-preview/pr-7718
Closed

github-actions[bot] wants to merge 2 commits into
developfrom
cf-preview/pr-7718

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

This PR mirrors fork PR #7718 for Cloudflare Pages preview builds.

Source PR: #7718
Source fork branch: tenderdeve/cowswap:fix/7686-unfillable-allowance-widget-ui
Mirrored SHA: bc520d2d15c3

Do not merge this PR. Close the source PR to clean up this mirror.

…modal

Two issues on the Account modal's "Unfillable" warning when the user
opened "Edit partial approval":

1. The amount preview at the top of the modal pulled from
   `useDerivedTradeState()`, which reflects the *current* trade form,
   not the pending order being warned about. With another (e.g. limit)
   order draft on the form, the preview showed the wrong sell/buy
   amounts.
2. The token symbol could wrap mid-line in the "Please top up X
   balance" copy.

Thread the order's `outputAmount` from `ActivityDetails` down through
`OrderFillabilityWarning` -> `OrderPartialApprove` ->
`PartialApproveAmountModal` -> `ChangeApproveAmountModal` /
`ChangeApproveAmountModalPure` to `SwapAmountPreview`, which now accepts
explicit `inputCurrencyAmount` / `outputCurrencyAmount` overrides and
only falls back to the derived trade state when none are provided.

Wrap the token symbol in the not-enough-balance copy in a `NoWrap` span
so it stays on a single line.

Closes #7686
@github-actions github-actions Bot added the DONT_MERGE Indicates the PR should not be merged. Probably a WIP or PoC. label Jun 23, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

Deploying explorer-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc520d2
Status: ✅  Deploy successful!
Preview URL: https://05af24c2.explorer-dev-dxz.pages.dev
Branch Preview URL: https://cf-preview-pr-7718.explorer-dev-dxz.pages.dev

View logs

@vercel

vercel Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cowfi Ready Ready Preview Jun 23, 2026 3:50pm
storybook Ready Ready Preview Jun 23, 2026 3:50pm
widget-configurator Ready Ready Preview Jun 23, 2026 3:50pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
cosmos Ignored Ignored Jun 23, 2026 3:50pm
sdk-tools Ignored Ignored Preview Jun 23, 2026 3:50pm

Request Review

@vercel
vercel Bot temporarily deployed to Preview – storybook June 23, 2026 14:58 Inactive
@vercel
vercel Bot temporarily deployed to Preview – widget-configurator June 23, 2026 14:59 Inactive
@vercel
vercel Bot temporarily deployed to Preview – cowfi June 23, 2026 15:00 Inactive
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

Deploying swap-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc520d2
Status: ✅  Deploy successful!
Preview URL: https://38ec545d.swap-dev-5u6.pages.dev
Branch Preview URL: https://cf-preview-pr-7718.swap-dev-5u6.pages.dev

View logs

@vercel
vercel Bot temporarily deployed to Preview – storybook June 23, 2026 15:48 Inactive
@vercel
vercel Bot temporarily deployed to Preview – widget-configurator June 23, 2026 15:49 Inactive
@vercel
vercel Bot temporarily deployed to Preview – cowfi June 23, 2026 15:50 Inactive
@github-actions github-actions Bot closed this Jun 26, 2026
@github-actions
github-actions Bot deleted the cf-preview/pr-7718 branch June 26, 2026 16:42

This branch was previously deployed

3 inactive deployments
Preview – cowfi — bc520d2d Deployed Jun 23, 2026 by vercel[bot]
Preview – widget-configurator — bc520d2d Deployed Jun 23, 2026 by vercel[bot]
Preview – storybook — bc520d2d Deployed Jun 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DONT_MERGE Indicates the PR should not be merged. Probably a WIP or PoC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants