Repository navigation
preview: mirror fork PR #7770 - #7771
Closed
github-actions[bot] wants to merge 3 commits into
Closed
github-actions[bot] wants to merge 3 commits into
github-actions[bot] wants to merge 3 commits into
Conversation
…the form The Turnstile widget only unmounted once the exchanged JWT was stored, so its built-in "Success!" box lingered on the trade form after the challenge was solved — and stayed indefinitely whenever the token exchange was slow or failed. Hide the widget as soon as the challenge succeeds while the exchange runs in the background, and reveal it again on expiry/error so a fresh challenge can be solved.
Deploying explorer-dev with
|
| Latest commit: |
2e4fb60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c74a72fd.explorer-dev-dxz.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7770.explorer-dev-dxz.pages.dev |
3 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying swap-dev with
|
| Latest commit: |
2e4fb60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e0b5835.swap-dev-5u6.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7770.swap-dev-5u6.pages.dev |
…success The previous approach hid the solved widget via display:none during the JWT exchange and re-showed it on failure, which re-rendered Cloudflare's stale "Success!" box even though the exchange had failed. Instead, leave the solved widget visible while the exchange runs, then: - on success, store the JWT (the widget unmounts, so the "Success!" box leaves the form) — the original issue; - on failure (or onError), reset the widget so it drops the stale "Success!" box and re-runs the challenge for the user to re-confirm.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors fork PR #7770 for Cloudflare Pages preview builds.
Source PR: #7770
Source fork branch:
tenderdeve/cowswap:fix/7768-captcha-dismissMirrored SHA:
2e4fb605abebDo not merge this PR. Close the source PR to clean up this mirror.