Repository navigation
Disable ahash runtime-rng to fix wasm build - #68
Open
sebastian-zm wants to merge 1 commit into
Open
sebastian-zm wants to merge 1 commit into
sebastian-zm wants to merge 1 commit into
Conversation
ahash 0.8.12's default `runtime-rng` feature pulls in getrandom 0.3, which refuses to compile for wasm32-unknown-unknown without the `getrandom_backend="wasm_js"` cfg. Since Cargo.lock is not committed, CI resolves to this version and the wasm-npm job fails. ahash is only used for tokenizer maps, which don't need DoS-resistant random keys, so turn off default features and keep `std`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ahash 0.8.12's default
runtime-rngfeature pulls in getrandom 0.3, which refuses to compile for wasm32-unknown-unknown without thegetrandom_backend="wasm_js"cfg. Since Cargo.lock is not committed, CI resolves to this version and the wasm-npm job fails. ahash is only used for tokenizer maps, which don't need DoS-resistant random keys, so turn off default features and keepstd.