fix(inventory): scale 3D modal with viewport, unify market action row - #412
Merged
Conversation
ykns3
marked this pull request as ready for review
August 4, 2026 20:18
Step7750
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #410, addressing @Step7750's review comments.
Modal size — the dialog now scales with the viewport instead of pinning to 1120px, using the same treatment as the market site's screenshot dialog: width follows 90vw, with a height-derived cap that keeps the 16:9 stage at or under 80vh. The side-panel layout (≥1520px) adds its 320px panel to the width budget; the item-strip layout (1168–1519px) adds its 122px strip to the height budget, with a 1120px floor so mid-size screens keep today's size. On a 1440p display the viewer stage grows from 1120×630 to ~1984×1116.
Action row — the CSFloat market action (list button or active listing, mutually exclusive) and the 3D button now share one flex row: the market action keeps the left slot whether the item is listed or not, and the buttons no longer wrap to new lines when there's room. Also adds a bit more gap between the float/paint seed info and the row.
Validation
npm run lint,npm run build,npm run checkformat,npm test(31/31).Note
Low Risk
CSS layout and inventory UI composition only; no auth, API, or data-path changes.
Overview
The SkinCraft 3D viewer dialog scales with the viewport instead of staying near a fixed 1120px width: default sizing uses
90vwand a 16:9 cap at 80vh (withdvhfallbacks and a 1920px stage ceiling). Breakpoints for the item strip and side panel fold those chrome dimensions into the width/height budget, use a 1120px floor on mid-width layouts, and drop the hard-coded stage width so the grid can grow with the dialog.In selected item info, the CSFloat list, active listing, and View in 3D actions share one flex row (listing is no longer rendered below), with
stallListingincluded in when that row appears so listed-only items still show the row. Spacing above the action row is slightly increased.Reviewed by Cursor Bugbot for commit 65e35c4. Bugbot is set up for automated code reviews on this repo. Configure here.