fix various bugs - #72
Merged
Merged
Conversation
- reject API keys from inactive marketplaces - batch limit reversal creation to 1000 per request - per-marketplace rate limits replace API key limits for non-admin routes. Prevents a quota bypass by rotating API keys.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a1f20f2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes auth validation and rate-limit identity for production API routes; inactive-marketplace behavior may surprise integrators who still hold valid keys.
Overview
Tightens marketplace lifecycle and API access so suspension and platform rules actually stick at runtime.
Admin PATCH now returns 403 when trying to set
is_active: falseon thecsfloatmarketplace (mirroring existing delete protection), with no DB update or audit record.Authentication rejects valid API keys when the linked marketplace is inactive (
ValidateKeytreats that like record not found), so deactivation blocks authenticated traffic.Reversal ingestion rejects empty
dataarrays and batches over 1,000 items before any DB work.Rate limiting on marketplace key management and reversal routes switches from per API key to per marketplace slug (
ThrottleByMarketplace), so rotating keys cannot bypass shared quotas.Reviewed by Cursor Bugbot for commit 03abd89. Bugbot is set up for automated code reviews on this repo. Configure here.