Skip to content

Windows: prove the app boots — electron/smoke.js on windows-latest CI #449

Closed

Description

@currentbits

Follow-up to #442. Nothing in CI proves Solenta starts on Windows; that is how a dead dispatch path survived. electron/smoke.js is already a full boot + IPC + fake-agent harness but runs nowhere in CI, and it uses 'which node' plus #!/usr/bin/env node fakes. Make it win32-clean and add it as a CI job.

Activity

  1. added and removed on Aug 18, 2026
  2. currentbits commented on Aug 18, 2026

    @currentbits
    OwnerAuthor

    Merged into the #397 branch. electron/smoke.js now runs on win32: resolveNodeBinary uses defaultWhich (where on win32), and each shebang fake gets a sibling .cmd running node <script> %* which is what CODER_BIN points at, since CreateProcess cannot exec a shebang and CODER_BIN must stay one token. macOS path unchanged. New smoke CI job on macos-latest + windows-latest, separate from npm test so a boot failure reads as a boot failure. Verified locally on macOS: all five passes, exit 0; missing dist exits 1. Windows stays unverified until the job runs.

  3. currentbits commented on Aug 18, 2026

    @currentbits
    OwnerAuthor

    The job landed and runs, but it is not green. Windows smoke dies on pass C (Claude fake → Run error (exit 0)) on every windows-latest run so far. Tracked in #480. macOS smoke is fine; pass A/B on Windows are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions