You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Windows: unlock the electron test suite (shebang fakes) #450
Follow-up to #442. 31 electron test files write #!/usr/bin/env node fake CLIs and pass them as CODER_*_BIN. CreateProcess cannot execute those, so the Windows CI leg runs 44 of ~1220 tests. Each file has its own local writeFake helper — no shared one. A shared win32-safe fake helper would unlock the bulk of the suite on Windows.
Merged into the #397 branch. One writeFakeBin (electron/test/support/fakeBin.js) replaces 32 local shebang writers; POSIX writes the same bytes as before, win32 adds a .cmd wrapper cross-spawn can launch. Win32 CI leg goes from 4 files / 44 tests to 21 / 238. gh and fm stay POSIX-only and are listed as such — they execFile the fake directly, which cannot run a .cmd. Verified no assertion or it() block was removed in the migration.
Activity
currentbits commentedon Aug 18, 2026
Merged into the #397 branch. One writeFakeBin (electron/test/support/fakeBin.js) replaces 32 local shebang writers; POSIX writes the same bytes as before, win32 adds a .cmd wrapper cross-spawn can launch. Win32 CI leg goes from 4 files / 44 tests to 21 / 238. gh and fm stay POSIX-only and are listed as such — they execFile the fake directly, which cannot run a .cmd. Verified no assertion or it() block was removed in the migration.