Skip to content

Windows: unlock the electron test suite (shebang fakes) #450

Closed

Description

@currentbits

Follow-up to #442. 31 electron test files write #!/usr/bin/env node fake CLIs and pass them as CODER_*_BIN. CreateProcess cannot execute those, so the Windows CI leg runs 44 of ~1220 tests. Each file has its own local writeFake helper — no shared one. A shared win32-safe fake helper would unlock the bulk of the suite on Windows.

Activity

  1. added and removed on Aug 18, 2026
  2. currentbits commented on Aug 18, 2026

    @currentbits
    OwnerAuthor

    Merged into the #397 branch. One writeFakeBin (electron/test/support/fakeBin.js) replaces 32 local shebang writers; POSIX writes the same bytes as before, win32 adds a .cmd wrapper cross-spawn can launch. Win32 CI leg goes from 4 files / 44 tests to 21 / 238. gh and fm stay POSIX-only and are listed as such — they execFile the fake directly, which cannot run a .cmd. Verified no assertion or it() block was removed in the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions