Skip to content

Electron suite: 7 pre-existing failures on main (verify-gate, checkpoints, web, store) #536

Closed

Description

@currentbits

Found while verifying a merge against origin/main (2026-08-18, origin/main at 9517511). These fail identically on pristine origin/main, so they are not merge artifacts.

  • electron/test/verify-gate.test.js — 0 pass / 4 fail (whole file red)
  • electron/test/checkpoints.test.js — 1 fail: "runner auto-checkpoint on successful turn" throws worktreeBase is not configured from materializePendingWorktree (runner.js) — the fixture's createRunner gets no userDataPath, and the Worktree creation failure must never silently run the agent in the main checkout #511 fail-closed path now requires it
  • electron/test/web.test.js — 1 fail
  • electron/test/store.test.js — 1 fail at store.test.js:106: thread object now carries reviewAcceptedHunks: [] which the expected fixture doesn't include

Repro: npm run test:electron on main.

Activity

  1. added
    bugSomething isn't working
    and removed on Aug 18, 2026
  2. currentbits commented on Aug 20, 2026

    @currentbits
    OwnerAuthor

    Fixed on coder/fork-electron-suite-7-pre-existing-failu-b31efc. These were fixture/assertion drift, not product bugs.

    verify-gate (4) + checkpoints (1): createRunner omitted userDataPath. After #511, materializePendingWorktree throws worktreeBase is not configured for any thread with worktreePath. Tests now pass userDataPath: fx.tmpDir so rematerialize uses tmpDir/worktrees (same as makeWorktreeFixture).

    web.test.js (2):

    • contextMenu:show is registered in registerIpc outside IPC_HANDLERS on purpose (native Menu.popup; the web bridge must not pop a menu). The ownership test skips it and still asserts ipcMain.handle("contextMenu:show").
    • package-app.sh copies ws via ROOT_NM_PKGS + node_modules/$pkg, not a literal node_modules/ws path (that string lives in verify-package.sh).

    store.test.js: already green on this tree — the round-trip fixture includes reviewAcceptedHunks: [] (and worktreeRetention: 10 after #559).

    Verified: those four files 78/78. Full npm run test:electron no longer reports any of the original seven; remaining reds are the known env suite (orch-server needs memory-server/node_modules).

  3. added and removed on Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingplan:donePlanboard status

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions