Repository navigation
Build devCoder on first use, not at import (#1439) - #1584
Merged
Merged
Conversation
Building the dev fixture starts the seeded working threads' run intervals, so importing src/devCoder.ts (via coderApi.ts) kept every importer alive ~3.5s after its work was done: each renderer test file and the CI eject/sidebar tests that timed out. devCoder is now a lazy getter; import exits in ~0.1s. Production builds still drop it (#1475). Ported from a local-only merge that never reached GitHub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1439 (eject/sidebar CI test instability). That issue was closed, but its fix only ever landed as a local-only merge and never reached GitHub. This is a port onto current main.
export const devCoder = buildDevCoder()builds the dev fixture at import. That starts the seeded working threads' run intervals, so anything importingsrc/coderApi.ts(each renderer test file) stays alive after its work is done. Measured on main: importingsrc/devCoder.tsexits after ~3.6 s; with this change, ~0.1 s.devCoderis now a lazy getter (devCoder()), andresolveCoderApicalls it.vite buildoutput contains none of its seed data.Tests:
tsc --noEmitis clean. The renderer suite passes 2943/2943 in 29 s, and so does the full electron suite (4539/4539, combined with #1435 and #1436).🤖 Generated with Claude Code