Repository navigation
Clickable file paths in the transcript open in the worktree - #506
Merged
Merged
Conversation
Detect repo-relative and absolute paths in assistant Markdown and tool-card headers/args, resolve them against the thread worktree, and open with shell.openPath (Cmd/Ctrl-click reveals in Finder). Fixes #492
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #492. Assistant Markdown and tool-card headers/args treated file paths as dead text — only
http(s)links were clickable. Review meant copy the path, switch to an editor, paste. The CLIs already did the click.Paths the model prints (
src/foo.ts,`src/foo.ts:40`, a Read/Edit card argument) now open the file in this thread's worktree, not the main checkout.What changed
:line/:line:col) in assistant Markdown and tool-card headers/args.shell.openPath. Cmd/Ctrl-click → reveal in Finder.thread.worktreePath(else the project root).files:resolvechecks existence and workspace membership; missing files, URLs, and npm names stay plain text.Out of scope: jumping the editor to a line (
data-path-lineis set, open still hands the file to the default app). Built-in editor remains #162.Tests
Covers relative file, missing file,
file:12, and http left alone. Renderer suite 1048 pass. Typecheck clean.