Support arbitrary scope and insertion delimiter for drop, float and puff#2646
Merged
Conversation
phillco
reviewed
Aug 11, 2024
phillco
approved these changes
Aug 11, 2024
phillco
self-requested a review
August 11, 2024 22:32
Co-authored-by: Phil Cohen <phillip@phillip.io>
phillco
reviewed
Aug 11, 2024
Co-authored-by: Phil Cohen <phillip@phillip.io>
phillco
approved these changes
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new implementation allows us to do things like
"puff token"to insert spaces."float item"to insert,etc. A bit like #2651.This new implementation also fixed a few bugs around where the selection and highlights ended up.
Note that there is still a bug with the range updater when you have an empty selection, but that is out of scope for this pr.
#729
Fixes #742
Checklist