Add modifiers, more special marks to cheatsheet#885
Merged
Conversation
pokey
reviewed
Jul 20, 2022
pokey
left a comment
pokey
left a comment
Member
There was a problem hiding this comment.
Ah sorry I really gotta add contributor docs for the new cheatsheet 😅. The defaults.json is just for making local development easier. The actual user json when the user says "cursorless cheatsheet" is generated here https://github.com/cursorless-dev/cursorless/blob/main/cursorless-talon/src/cheatsheet_html/cheat_sheet.py#L33
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
brollin
marked this pull request as draft
July 20, 2022 09:14
brollin
changed the title
Contributor
Author
|
Wasn't fully using my brain when beginning this task 🙃 but after your comment and perusing some more, I have a better grasp of things. I think! :) Here is what I've got so far:
I'm thinking that some of the "Meaning"s should be adjusted, which I can tackle tomorrow. |
brollin
marked this pull request as ready for review
July 20, 2022 20:48
pokey
approved these changes
Aug 3, 2022
pokey
left a comment
pokey
left a comment
Member
There was a problem hiding this comment.
Looks good to me; made a bunch of tweaks though so lmk what you think
Contributor
Author
|
All the changes look good to me 👍 |
cursorless-bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
* add bounds,inside,row,up,down to cheatsheet * use correct ids * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * # -> number * include line_direction special marks in cheatsheet * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add modifiers section to cheatsheet * Better special mark descriptions * Modifiers descriptions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * modifier description fix up * update spoken form defaults * Various improvements * Revert accidental change Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
* add bounds,inside,row,up,down to cheatsheet * use correct ids * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * PR comment Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> * # -> number * include line_direction special marks in cheatsheet * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add modifiers section to cheatsheet * Better special mark descriptions * Modifiers descriptions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * modifier description fix up * update spoken form defaults * Various improvements * Revert accidental change Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #873, closes #636, partially addresses #667. Will check a few boxes in #840.