fix(react): keep loader results out of snapshots (FEP-2613) - #741
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughLoader results are moved from serialized activity contexts into ChangesLoader result reference flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Navigation
participant loaderPlugin
participant LoaderResultStore
participant Activity
participant useLoaderData
Navigation->>loaderPlugin: execute loader
loaderPlugin->>LoaderResultStore: store result and create loaderResultId
loaderPlugin->>Activity: write loaderResultId to activityContext
loaderPlugin->>LoaderResultStore: retrieve promise by loaderResultId
LoaderResultStore-->>loaderPlugin: return loader promise
loaderPlugin->>Activity: render with LoaderResultContext.Provider
useLoaderData->>Activity: read LoaderResultContext
Activity-->>useLoaderData: provide loader promise
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying stackflow-demo with
|
| Latest commit: |
0c56baa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0aca274.stackflow-demo.pages.dev |
| Branch Preview URL: | https://feature-fep-2613-loader-resu.stackflow-demo.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 0c56baa | Commit Preview URL | Jul 30 2026, 08:07 AM |
🦋 Changeset detectedLatest commit: 0c56baa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@stackflow/link
@stackflow/plugin-basic-ui
@stackflow/plugin-blocker
@stackflow/plugin-google-analytics-4
@stackflow/plugin-history-sync
@stackflow/plugin-lifecycle
@stackflow/plugin-renderer-basic
@stackflow/plugin-renderer-web
@stackflow/react-ui-core
@stackflow/react
commit: |
Uh oh!
There was an error while loading. Please reload this page.