Repository navigation
Add support for Aryl-Aryl atropisomerism - #353
Conversation
Places where null was being checked need to now check the bond is CisTrans. New utility methods hasCisTransSpecified() / hasAtropisomerSpecified() have been added.
The locant handling is implemented but the locant's don't seem to make it through (grammar change needed?).
Handling of warnings/errors.
As far as I can see this is using CxSMILES official wedge syntax, so syntactically it's not an extension of CxSMILES even if it is semantically What do you think about having this enabled by default in the "extended SMILES" output. My concern if this isn't done is that it would mean that none of the output modes included this, effectively meaning that this stereochemistry is ignored despite there being no warning. I think axial stereochemistry in principle can be used with Rac/Rel (atleast RDKit seems to support it:https://www.rdkit.org/docs/RDKit_Book.html#enhanced-stereochemistry), do you want this combination rejected for the moment? Tangentially to this PR I've noticed that the public |
|
I also think there is a difference between I have an (M) annotated and I have know idea what you are talking about vs I know what you are talking about I just can't give you back a representation of it. But yes it did cross my mind perhaps a new layer of warning might be needed. "Structure has features which are not universally representable" i.e. you can get a CXSMILES but InChI/MOLfile/SMILES will not have everything.
I thought I would let you make that call. It is a fudge though, not sure if you rememeber but in OpenBabel 0d molfiles where you could store cis/trans double bonds using wedges: 🤮 I personal would much prefer a proper extension (new syntax) which allows left/right annotation. Sticking with existing syntax I think a better way to have don it would be with a data sgroup, since you can attach data to sets of atoms: This is much cleaner but alas RDKit already has it's way so adding another divergent one would be bad. RDKit is uses enough I think it is reasonable to just at it to default CXSMILES.
Yes - but there is no way to annotated bonds with the rac/rel (and/or) groups in CXSMILES. In fact this is already an issue as I think OPSIN when we added that as (E/Z)-but-2-ene or (EZ)-but-2-ene also occur. Not Rac/Rel but still a mixture of isomers. We have it stored in the OPSIN internals I think but can't write it out. It's perhaps a place where CML becomes useful again to capture everything. BIOVIA molfiles now support bond rac/rel - not clear if it is just for atropisomers or cis/trans to. Alas I'm not sure if ChemAxon are really that active in adding new things. The data sgroups above is an option. |
Is functional and ready but...