Skip to content

Updating workflow API to no longer point to alpha API - #1151

Closed
RyanLettieri wants to merge 1 commit into
dapr:masterfrom
RyanLettieri:workflow-beta-api
Closed

RyanLettieri wants to merge 1 commit into
dapr:masterfrom
RyanLettieri:workflow-beta-api

Conversation

@RyanLettieri

Copy link
Copy Markdown
Contributor

Description

Editted readme and samples for workflow API to no longer reference alpha.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
@RyanLettieri
RyanLettieri requested review from a team as code owners September 25, 2023 16:03
@RyanLettieri RyanLettieri changed the title Updating workflow to API to no longer point to alpha API Updating workflow API to no longer point to alpha API Sep 25, 2023
@codecov

codecov Bot commented Sep 25, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (fd7168f) 66.45% compared to head (b7c94a3) 66.42%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   66.45%   66.42%   -0.03%     
==========================================
  Files         171      171              
  Lines        5750     5758       +8     
  Branches      624      626       +2     
==========================================
+ Hits         3821     3825       +4     
- Misses       1782     1784       +2     
- Partials      147      149       +2     
Flag Coverage Δ
net6 66.42% <ø> (-0.03%) ⬇️
net7 66.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@halspang

Copy link
Copy Markdown
Contributor

We ended up including these changes in #1194, closing this PR.

@halspang halspang closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants