Adds an option to set a timeout for service invocation by elena-kolevska · Pull Request #1252 · dapr/dotnet-sdk

elena-kolevska · 2024-03-18T19:29:59Z

Description

Adds an option to set a timeout for http and grpc

Issue reference

#1007

Checklist

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: Elena Kolevska <elena@kolevska.com>

codecov · 2024-03-18T19:33:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (1b7c9f4) to head (b5962f1).
Report is 1 commits behind head on master.

❗ Current head b5962f1 differs from pull request most recent head c37f86b. Consider uploading reports for the commit c37f86b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   67.28%   67.31%   +0.02%     
==========================================
  Files         174      174              
  Lines        6025     6030       +5     
  Branches      671      672       +1     
==========================================
+ Hits         4054     4059       +5     
  Misses       1802     1802              
  Partials      169      169

Flag	Coverage Δ
net6	`67.29% <100.00%> (+0.02%)`	⬆️
net7	`67.29% <100.00%> (+0.02%)`	⬆️
net8	`67.29% <100.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Elena Kolevska <elena@kolevska.com>

…tly to the call as shown in the updated tests and docs Signed-off-by: Elena Kolevska <elena@kolevska.com>

philliphoff · 2024-04-08T17:06:50Z

        // property exposed for testing purposes
        internal GrpcChannelOptions GrpcChannelOptions { get; private set; }
        internal string DaprApiToken { get; private set; }
+        internal TimeSpan Timeout { get; private set; } // in milliseconds


Nit: remove comment? (No longer in milliseconds?)

Good catch, thanks. Done!

philliphoff

Just one nit re: comments, otherwise looks good.

Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>

marcduiker · 2024-04-24T13:53:43Z

@holopin-bot @elena-kolevska Thanks Elena! 😁

holopin-bot · 2024-04-24T13:53:47Z

Congratulations @elena-kolevska, you just earned a badge! Here it is: https://holopin.io/claim/clvdvlg1657300gji363rwirt

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

taufan-mft · 2024-05-31T07:09:41Z

hi guys, first of all thank you for this PR. I've build this version locally and it solved what I needed. Any idea on when this will be included in the release sir @philliphoff ?

philliphoff · 2024-06-06T18:14:54Z

@taufan-mft It should be part of the v1.14 Dapr release. You can follow its progress in its release planning issue here: dapr/dapr#7605

taufan-mft · 2024-06-07T04:08:14Z

thanks a lot! @philliphoff @elena-kolevska

* Adds http timeout Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds a timeout for the grpc client Signed-off-by: Elena Kolevska <elena@kolevska.com> * Small updates Signed-off-by: Elena Kolevska <elena@kolevska.com> * Updates test Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds a timeout example in docs Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds e2e test for http service invocation Signed-off-by: Elena Kolevska <elena@kolevska.com> * Adds tests for grpc service invocation Signed-off-by: Elena Kolevska <elena@kolevska.com> * Removes grpc timeout, because it’s not needed. It can be passed directly to the call as shown in the updated tests and docs Signed-off-by: Elena Kolevska <elena@kolevska.com> * Update src/Dapr.Client/DaprClientBuilder.cs Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com> Co-authored-by: Phillip Hoff <phillip@orst.edu> Signed-off-by: Divya Perumal <diperuma@microsoft.com>

elena-kolevska added 4 commits March 12, 2024 10:26

Adds http timeout

3070d91

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Adds a timeout for the grpc client

b473d79

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Small updates

bab2f21

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Updates test

58027c1

Signed-off-by: Elena Kolevska <elena@kolevska.com>

elena-kolevska added 3 commits March 18, 2024 20:32

Adds a timeout example in docs

4c3bce9

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Adds e2e test for http service invocation

f3354b4

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Adds tests for grpc service invocation

23729fc

Signed-off-by: Elena Kolevska <elena@kolevska.com>

elena-kolevska force-pushed the feature/timeout branch from a3a92cd to 23729fc Compare March 18, 2024 23:32

elena-kolevska marked this pull request as ready for review March 18, 2024 23:41

elena-kolevska requested review from a team as code owners March 18, 2024 23:41

Removes grpc timeout, because it’s not needed. It can be passed direc…

b5962f1

…tly to the call as shown in the updated tests and docs Signed-off-by: Elena Kolevska <elena@kolevska.com>

elena-kolevska changed the title ~~Adds an option to set a timeout for http and grpc~~ Adds an option to set a timeout for service invocation Apr 5, 2024

philliphoff reviewed Apr 8, 2024

View reviewed changes

philliphoff previously approved these changes Apr 8, 2024

View reviewed changes

Merge branch 'master' into feature/timeout

6cb8dbe

elena-kolevska commented Apr 8, 2024

View reviewed changes

Comment thread src/Dapr.Client/DaprClientBuilder.cs Outdated

Update src/Dapr.Client/DaprClientBuilder.cs

c37f86b

Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>

elena-kolevska dismissed philliphoff’s stale review via c37f86b April 8, 2024 17:14

philliphoff approved these changes Apr 8, 2024

View reviewed changes

philliphoff merged commit bdca3b3 into dapr:master Apr 8, 2024

philliphoff added this to the v1.14 milestone Jul 23, 2024

philliphoff mentioned this pull request Jul 23, 2024

How to set the DaprClient invoke timeout #1007

Closed

This was referenced Sep 10, 2025

Bump Dapr.Actors from 1.13.0 to 1.15.4 mbn-ms-dk/AspireDTC#30

Closed

Bump Dapr.Actors and Dapr.Actors.AspNetCore mbn-ms-dk/AspireDTC#31

Open

Bump Dapr.AspNetCore from 1.13.0 to 1.15.4 mbn-ms-dk/AspireDTC#32

Closed

dependabot Bot mentioned this pull request Sep 17, 2025

Bump Dapr.AspNetCore from 1.13.0 to 1.16.0 mbn-ms-dk/AspireDTC#33

Open

This was referenced Mar 19, 2026

Bump Dapr.Client from 1.4.0 to 1.15.4 azureossd/Container-Apps#128

Closed

Bump Dapr.Client from 1.4.0 to 1.15.4 azureossd/Container-Apps#132

Merged

Bump Dapr.Client from 1.4.0 to 1.15.4 azureossd/Container-Apps#136

Merged

dependabot Bot mentioned this pull request Apr 14, 2026

Bump the dotnet-packages group with 6 updates CorneHogerheijde/KwintBaseHarmony#3

Merged

dependabot Bot mentioned this pull request Aug 19, 2026

Bump Dapr.AspNetCore from 1.11.0 to 1.18.5 ondfisk/SecurityDemo#13

Closed

dependabot Bot mentioned this pull request Sep 11, 2026

Bump Dapr.AspNetCore from 1.11.0 to 1.18.7 ondfisk/SecurityDemo#20

Closed

This was referenced Sep 21, 2026

Bump Dapr.AspNetCore from 1.11.0 to 1.18.8 ondfisk/SecurityDemo#21

Closed

Bump Dapr.AspNetCore from 1.11.0 to 1.18.10 ondfisk/SecurityDemo#22

Open

Navigation Menu

Adds an option to set a timeout for service invocation - #1252

Adds an option to set a timeout for service invocation#1252
philliphoff merged 10 commits into
dapr:masterfrom
elena-kolevska:feature/timeout

elena-kolevska commented Mar 18, 2024 •

edited

Loading

Uh oh!

codecov Bot commented Mar 18, 2024 •

edited

Loading

Uh oh!

philliphoff Apr 8, 2024

Uh oh!

elena-kolevska Apr 8, 2024

Uh oh!

philliphoff left a comment

Uh oh!

Uh oh!

marcduiker commented Apr 24, 2024

Uh oh!

holopin-bot Bot commented Apr 24, 2024

Uh oh!

taufan-mft commented May 31, 2024

Uh oh!

philliphoff commented Jun 6, 2024

Uh oh!

taufan-mft commented Jun 7, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

elena-kolevska commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

codecov Bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

philliphoff Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

elena-kolevska Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

philliphoff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcduiker commented Apr 24, 2024

Uh oh!

holopin-bot Bot commented Apr 24, 2024

Uh oh!

taufan-mft commented May 31, 2024

Uh oh!

philliphoff commented Jun 6, 2024

Uh oh!

taufan-mft commented Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elena-kolevska commented Mar 18, 2024 •

edited

Loading

codecov Bot commented Mar 18, 2024 •

edited

Loading

taufan-mft commented Jun 7, 2024 •

edited

Loading