Skip to content

Updated .github/holopin.yml. Fixes #1270 - #1276

Merged
philliphoff merged 1 commit into
dapr:masterfrom
cmendible:master
Apr 23, 2024
Merged

philliphoff merged 1 commit into
dapr:masterfrom
cmendible:master

Conversation

@cmendible

Copy link
Copy Markdown
Member

Description

Updated .github/holopin.yml.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1270

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cmendible
cmendible requested review from a team as code owners April 23, 2024 10:29
Signed-off-by: Carlos Mendible <266546+cmendible@users.noreply.github.com>

@marcduiker marcduiker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philliphoff
philliphoff merged commit ba13415 into dapr:master Apr 23, 2024
@philliphoff

Copy link
Copy Markdown
Collaborator

@cmendible Thanks for the PR!

@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @cmendible Thanks Carlos! 🎉

@holopin-bot

holopin-bot Bot commented Apr 24, 2024

Copy link
Copy Markdown

Congratulations @cmendible, you just earned a badge! Here it is: https://holopin.io/claim/clvdj0rw3283900fjsto83kzx3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@philliphoff philliphoff added this to the v1.14 milestone Jul 23, 2024
divzi-p pushed a commit to divzi-p/dotnet-sdk that referenced this pull request Dec 10, 2024
Signed-off-by: Carlos Mendible <266546+cmendible@users.noreply.github.com>
Signed-off-by: Divya Perumal <diperuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the holopin.yml to use the sdk badge

3 participants