Fixed ConversationOptions not accepting unset ConversationId - #1480
Merged
Merged
Conversation
…owing Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
This was referenced Sep 10, 2025
This was referenced Nov 17, 2025
This was referenced Mar 19, 2026
This was referenced Apr 14, 2026
This was referenced Sep 11, 2026
Open
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A developer can pass options into the Conversations API that change the behavior. When options are passed today without a
ConversationIdvalue, this throws as it expects that to be populated.This patch fixes this -
ConversationIdis optional and will be treated as such.Thanks for spotting this issue @marcduiker !
Issue reference
N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: