Skip to content

bugfix: (actors) - Fixing bug with inconsistent actor state - #1946

Merged
WhitWaldo merged 1 commit into
masterfrom
actor-state-bugfix
Oct 20, 2026
Merged

WhitWaldo merged 1 commit into
masterfrom
actor-state-bugfix

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Fixing inconsistent actor state bug since it marked changes clean before persistence succeeded. This means that retries after failed or cancelled saves silently skipped writes.

This issue does not impact Dapr.Actors.Next.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1616

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…ore persistence succeeded.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.19 milestone Oct 20, 2026
@WhitWaldo WhitWaldo self-assigned this Oct 20, 2026
@WhitWaldo
WhitWaldo requested review from a team as code owners October 20, 2026 22:04
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.39%. Comparing base (008b782) to head (9540bc5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1946      +/-   ##
==========================================
+ Coverage   68.33%   68.39%   +0.05%     
==========================================
  Files         376      376              
  Lines       10876    10877       +1     
  Branches     1274     1275       +1     
==========================================
+ Hits         7432     7439       +7     
+ Misses       3100     3097       -3     
+ Partials      344      341       -3     
Flag Coverage Δ
net10.0 68.37% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo
WhitWaldo merged commit b0f624f into master Oct 20, 2026
403 checks passed
@WhitWaldo
WhitWaldo deleted the actor-state-bugfix branch October 20, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sporadic inconsistent actor state is returned through multiple ActorInterfaceMethod and ReminderMethod invocations

1 participant