test(device): fold EndToEndTests into DaqifiDeviceWithTransportTests

[tylerkron]

Summary

src/Daqifi.Core.Tests/Integration/EndToEndTests.cs was a stray one-file folder whose four facts overlapped the device transport tests that live next to the production code. Two facts were pure duplicates. The other two pinned behavior nothing else covers, so they move into DaqifiDeviceWithTransportTests instead of being dropped. The file, its private MockMemoryStreamTransport (a copy of MockStreamTransport), and the Integration folder go away. No project, solution, CI or filter plumbing referenced the folder.

Deleted (already covered)

• EndToEnd_DeviceWithStreamConstructor_ShouldMaintainBackwardCompatibility is identical to DaqifiDeviceWithMessageProducerTests.DaqifiDevice_SendMessage_WhenConnected_ShouldWriteToStream: stream constructor, connect, send SYSTem:SYSInfoPB?, disconnect, assert on the stream.
• EndToEnd_MessageProducerLifecycle_ShouldHandleStartStopCorrectly connects, sends, disconnects twice onto the same MemoryStream. DaqifiDevice_DisconnectThenConnect_SendsToCurrentTransportStream is stronger. It rotates the transport stream between cycles and requires the post-reconnect send to land on the new one. Connect writes nothing to the stream itself, so its NotEmpty check really is the second send.

Kept, moved next to DaqifiDevice_WithMockTransport_ShouldConnectAndSendMessages

• EndToEnd_MockTransport_ShouldDeliverSCPICommands → DaqifiDevice_Disconnect_FlushesEveryQueuedCommandInOrder. The twin sends one command. A single write can already be done before Disconnect runs, so it cannot tell a Disconnect that drains the producer queue (StopSafely) from one that clears it (Stop). MessageProducerTests pin multi-message draining at the producer level, not through DaqifiDevice.Disconnect. The moved fact queues four commands through device.Send and then disconnects. It now also asserts they reach the stream in order (it used Contains before). The status-event assertions are dropped because the twin already makes exactly those.
• EndToEnd_MultipleDevices_ShouldWorkIndependently → DaqifiDevice_TwoDevicesOnSeparateTransports_EachWritesOnlyToItsOwnStream. No other test connects two DaqifiDevice instances at once. If a producer, queue or stream ever got shared between instances, this is the only test that would catch it.

Both use the class's existing MockStreamTransport, which gains a GetWrittenContent() helper.

Out of scope

No production changes. No edits to ConnectionGuard, LiveCsv, Firmware or StreamMessageConsumer tests.

  

🤖 Generated with Claude Code

[tylerkron]

/agentic_review

[qodo-code-review]

PR Summary by Qodo

Consolidate device end-to-end tests with transport tests

🧪 Tests 🕐 10-20 Minutes

AI Description

• Move queued-command draining and two-device isolation coverage into the device transport tests.
• Strengthen queued-command coverage by asserting every command reaches the stream in order.
• Remove duplicate end-to-end tests and their redundant mock transport.

Diagram

graph TD
  T["Device transport tests"] --> D1["Device A"] --> P1["Producer A"] --> M1["Mock transport A"]
  T --> D2["Device B"] --> P2["Producer B"] --> M2["Mock transport B"]

Loading

High-Level Assessment

Consolidating the distinct behavioral checks beside existing transport tests preserves coverage while eliminating a duplicate mock and test fixture. Keeping a separate integration suite would add maintenance cost without testing a different boundary.

Files changed (1) +57 / -0

Tests (1) +57 / -0

DaqifiDeviceWithTransportTests.csPreserve command-draining and device-isolation coverage +57/-0

Preserve command-draining and device-isolation coverage

• Adds a helper to read the existing mock transport's captured output. Adds tests that verify disconnect delivers four queued commands in order and that two connected devices write only to their respective transports.

src/Daqifi.Core.Tests/Device/DaqifiDeviceWithTransportTests.cs

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[tylerkron]

Qodo-clean, CI green — ready for review