docs(adr): correct ADR 0001 evidence left by the living-audit deferral

[tylerkron]

Unblocked residue of the ADR 0001 living-audit deferral. Docs only, and only the two stale evidence paragraphs in docs/adr/0001-firmware-feature-gating.md. Stays out of #759’s hunks (Decision 1, the DeviceFeature sketch, consequences, and the living-audit rewrite); a git merge-tree of this branch with #759's head merges cleanly. Does not touch docs/DEVICE_INTERFACES.md.

What was wrong

Checked against current main and the firmware repo's releases:

• The release timeline stopped at v3.7.2 and called it "current firmware HEAD". Two newer tags now exist, both pre-releases: v3.7.3 (2026-08-31), which is v3.7.2 plus cherry-picked SD fixes and adds the __TRANSFER_ERROR__ marker on a mid-transfer SD:GET read error (firmware ContinuousDeviceFinder: a timed-out pass and a metadata-only change are both silent, so a UI cannot tell degraded discovery from quiet discovery #725, already documented in SdCardTransferErrorException and SdCardFileReceiver), and v3.8.0 (2026-09-06), which supersedes v3.7.3 and includes its fixes. v3.7.2 is still the latest full release.
• The enabling-fact paragraph said core does not parse the numeric SCPI code, and cited DaqifiStreamingDevice.IsScpiErrorLine, which does not exist. The classifier is ScpiResponseClassifier.IsScpiErrorLine, the parser is ScpiResponseClassifier.TryExtractErrorCode, and SdCardOperations.GetSdCardStorageAsync already throws FeatureNotSupportedException on -113.

What changed

• The timeline now marks v3.7.2 as the latest full release (as of 2026-09) and adds v3.7.3 (pre-release, the ContinuousDeviceFinder: a timed-out pass and a metadata-only change are both silent, so a UI cannot tell degraded discovery from quiet discovery #725 marker) and v3.8.0 (pre-release, supersedes v3.7.3). It no longer calls any tag "current HEAD", which goes stale with every release. The v3.7.0 SD-over-WiFi sentence is unchanged.
• The enabling-fact citations and the "does not yet parse" claim now match the code.

No decision text, no feature table, no benchmarks.

  

🤖 Generated with Claude Code

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Previous reviews

Review updated until commit 0e4f3bb ⏭️ Skipped

Results up to commit 3a0f87f ⏭️ Skipped

No changes from previous review

[qodo-code-review]

PR Summary by Qodo

Correct ADR 0001 firmware and SCPI evidence

📝 Documentation 🕐 Less than 5 minutes

AI Description

• Updates firmware HEAD evidence to v3.7.3 and records SD transfer-error behavior.
• Aligns SCPI classification, numeric parsing, and feature-gating evidence with current core code.

Diagram

graph TD
  FW["Firmware v3.7.3"] -->|release evidence| ADR["ADR 0001 audit"]
  SCPI["SCPI classifier"] -->|classification and parsing| ADR
  SD["SD operations"] -->|minus 113 behavior| ADR

Loading

High-Level Assessment

The narrow documentation-only correction is optimal because it fixes stale evidence without modifying ADR decisions or overlapping the deferred living-audit rewrite. A broader ADR revision was considered but would unnecessarily expand scope and conflict risk.

Files changed (1) +6 / -5

Documentation (1) +6 / -5

0001-firmware-feature-gating.mdCorrect firmware HEAD and SCPI parsing evidence +6/-5

Correct firmware HEAD and SCPI parsing evidence

• Updates the firmware timeline to identify v3.7.3 as current HEAD and records the SD transfer-error marker. Replaces stale SCPI references with the actual classifier, numeric-code parser, and existing -113 feature-not-supported behavior.

docs/adr/0001-firmware-feature-gating.md

[tylerkron]

/agentic_review

[qodo-code-review]

Code review by qodo was updated up to the latest commit 0e4f3bb

[tylerkron]

Qodo-clean, CI green — ready for review