Conversation
Drop fourteen facts whose assertions are already made by a broader sibling in the same file. Production code is unchanged. Co-authored-by: Tyler Kron <tylerkron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes fourteen unit-test facts in
src/Daqifi.Core.Testswhose assertions are already made by a broader sibling in the same file. No production code, MCP, Core library sources, orStreamMessageConsumerIntegrationTestschanges.CreateRequestVersionMessage_StartsWithSoh,CreateRequestVersionMessage_EndsWithEot,CreateEraseFlashMessage_StartsWithSohEndsWithEot,CreateProgramFlashMessage_StartsWithSohEndsWithEot,CreateJumpToApplicationMessage_StartsWithSohEndsWithEot,CreateReadCrcMessage_StartsWithSohEndsWithEotAllMessages_HaveValidFraming(SOH/EOT on all five messages). Opcode, DLE, and CRC facts stay.ParseHexRecords_ValidChecksum_DoesNotThrowParseHexRecords_HexParsingConversion_CorrectBytesparses the same:020000041D00DDrecord and checks every byte.ParseHexRecords_InvalidChecksum_ThrowsInvalidDataExceptionstays.PopulateChannelsFromStatus_WithZeroResolution_UsesDefaultResolution,PopulateChannelsFromStatus_WithZeroResolution_SetsResolutionIsAssumedPopulateChannelsFromStatus_WithUnusableResolution_FallsBackWithoutThrowingwith0uasserts resolution65535andResolutionIsAssumedon both the create and reuse paths.Activate_NullPortName_ThrowsArgumentNullException,Deactivate_NullPortName_ThrowsArgumentNullExceptionNullPortName_BothDirections_BlameThePortNameParameterthrowsArgumentNullExceptionnamingportNamefor both directions.ActivateAsync_NullPortName_ThrowsArgumentNullExceptionandDeactivateAsync_NullPortName_ThrowsArgumentNullExceptionstay.DecodeVersionResponse_WithNullData_ThrowsArgumentNullExceptionNamingData,DecodeProgramFlashResponse_WithNullData_ThrowsArgumentNullExceptionNamingData,DecodeEraseFlashResponse_WithNullData_ThrowsArgumentNullExceptionNamingDataAllFourDecoders_WithNullData_ThrowTheSameArgumentNullExceptioncompares those three to the exception fromDecodeReadCrcResponse_WithNullData_ThrowsArgumentNullExceptionNamingData(type,dataparameter, message).ShouldSkip_SeveralPlatformsNamed_SkipsOnEachOfThemShouldSkip_TwoOfThreeNamed_RunsOnTheThirdskips on each named platform in a combined flag and runs on the one that is not named.Does not overlap #770, #771, #781, #790, or #805–#811.
Test plan
dotnet testthe six affected classes on net9.0 and net10.0: 166 passed, 0 failed on each TFM