Conversation
Now default to `true`. New coercions: * Passing `--web-hot-reload` coerces canary mode to `true`. * Setting 'amd' module format coerces canary mode to `false`.
Package publishingIf you have publishing permissions, you can use the links below to publish the changes after merging this PR.
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
nshahan
changed the title
Markzipan
reviewed
Sep 14, 2026
| ); | ||
| }); | ||
|
|
||
| // TODO(nshahan): Remove when DDC no longer requires canary + ddc modules for |
Contributor
There was a problem hiding this comment.
Should we link to the tracking bug for this in github?
Markzipan
approved these changes
Sep 14, 2026
Markzipan
left a comment
Markzipan
left a comment
Contributor
There was a problem hiding this comment.
The approach looks good! We should add a cleanup item for when canary needs to be 'reset'. Its semantics have unfortunately drifted between webdev (just canary) and build_runner (synonymous with hot reload).
nshahan
marked this pull request as ready for review
September 16, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
canaryFeaturesflag now defaults totrueto match the expected value for themoduleFormatdefault.New coercions based on the expected intent when setting other flags:
--web-hot-reloadcoerces canary mode totrue.false.The existing tests were passing because they always set the module format and canary flags explicitly.
The actual usage in VSCode saw the
canaryFeaturesflag default value in some code paths leading toinconsistent settings.
Fixes: #2869