Skip to content

fix(dashmate): reset platform affects core - #1001

Merged
shumkov merged 1 commit into
v0.24-devfrom
fix/dashmate/reset_platform_affects_core
Apr 28, 2023
Merged

fix(dashmate): reset platform affects core#1001
shumkov merged 1 commit into
v0.24-devfrom
fix/dashmate/reset_platform_affects_core

Conversation

@shumkov

@shumkov shumkov commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

The reset command with --platform flag affects core as well

What was done?

  • Filter out core containers to remove

How Has This Been Tested?

Manually

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
shumkov requested a review from antouhou as a code owner April 28, 2023 18:00
@shumkov
shumkov merged commit edfc139 into v0.24-dev Apr 28, 2023
@shumkov
shumkov deleted the fix/dashmate/reset_platform_affects_core branch April 28, 2023 18:23
@shumkov shumkov added this to the v0.24.0 milestone Apr 28, 2023
QuantumExplorer added a commit that referenced this pull request Sep 11, 2026
Keep the workspace bincode alias for grovedb-bincode 2.1.0. v4.2-dev
moved rust-dashcore to 697bfb72, the pre-squash head of rust-dashcore
#989 (dash-spv derived-script fix), which predates the grovedb-bincode
switch from #1005; pin rust-dashcore dev at e4208c90 instead, the squash
merge of #989, which carries both, plus the two key-wallet fixes merged
in between (#1001, #1004).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants