style(drive-abci): rustfmt the keep-history deletion replay test - #4642
style(drive-abci): rustfmt the keep-history deletion replay test#4642llbartekll wants to merge 1 commit into
Conversation
`cargo fmt --all -- --check` fails on `v4.2-dev` at `batch/tests/document/deletion.rs:406`. The test name is long enough that rustfmt wants the opening brace on its own line and the call broken before `.await`; the merged form kept both on one line. This is the only formatting violation in the workspace, and it fails the "Rust wallet tests (macOS)" job for every PR branched off `v4.2-dev` — the job runs the fmt check before the tests, so nothing downstream of it gets to run. Introduced by 88b0427 (#4218). Pure rustfmt output, no logic touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request reformats one document deletion test. It does not change test behavior or public declarations. ChangesDocument deletion test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only reformats a document-deletion replay test and does not alter its behavior or production functionality. It is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Queued for automated review — 21st in line, estimated start in ~7 h (commit ef7c09a)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4642 +/- ##
============================================
+ Coverage 85.34% 85.38% +0.04%
============================================
Files 2795 2796 +1
Lines 373566 373611 +45
============================================
+ Hits 318827 319020 +193
+ Misses 54739 54591 -148
🚀 New features to boost your workflow:
|
|
Superseded — 🤖 Closed by Claude Code |
Issue being fixed or feature implemented
cargo fmt --all -- --checkcurrently fails onv4.2-devitself. TheRust wallet tests (macOS)job runs that check before the tests, so it exits 1after ~14s and every PR branched off
v4.2-devshows red — including onesthat touch none of the affected code.
Reproduced on a pristine
v4.2-devcheckout with nothing else applied:That is the only formatting violation in the whole workspace.
What was done?
Ran
cargo fmt --all. The test nametest_document_delete_on_document_type_that_keeps_history_replays_protocol_version_13is long enough that rustfmt wants the opening brace on its own line and the
call broken before
.await; the merged form kept both on one line.Pure rustfmt output — no logic, no test semantics, one file, six lines.
Introduced by 88b0427 (#4218).
How Has This Been Tested?
cargo fmt --all -- --check— exit 1 before, exit 0 after ✅The change is whitespace only, so it cannot affect behaviour; the surrounding
deletion_testsmodule is unchanged otherwise.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit