refactor: change dpp to be based on platform value - #809
Merged
Conversation
shumkov
requested changes
Feb 27, 2023
qrayven
previously approved these changes
Feb 27, 2023
…form into refactor/removeDocumentStub
…form into refactor/removeDocumentStub
…form into refactor/removeDocumentStub
QuantumExplorer
marked this pull request as ready for review
March 21, 2023 20:10
antouhou
approved these changes
Mar 22, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
A fundamental way how DPP used to work was that it was based on serde-json values that we often call JsonValue. This value system is not ideal for validation because it isn't very type rich. On top of that a lot of boilerplate code had to be used to get very simple functionality. Validation would require modifying the value between array buffers and bytes, and often by doing so data would be lost.
What was done?
We replaced the serde-json Value system with a new better typed platform-value system.
How Has This Been Tested?
All tests are passing, a lot more have been added.
Breaking Changes
Checklist:
For repository code-owners and collaborators only